Skip to content

Support Adobe Lock Files - #10260

Merged
i2h3 merged 1 commit into
masterfrom
i2h3/funny-cerf-5f1fed
Jun 29, 2026
Merged

Support Adobe Lock Files#10260
i2h3 merged 1 commit into
masterfrom
i2h3/funny-cerf-5f1fed

Conversation

@i2h3

@i2h3 i2h3 commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Resolves

#10237

Summary

Add support locking Adobe files on the server based on local lock files.

Checklist

AI (if applicable)

@i2h3 i2h3 added this to the 34.0.0 milestone Jun 26, 2026
@i2h3 i2h3 self-assigned this Jun 26, 2026
@i2h3 i2h3 added os: 🍎 macOS Apple macOS, formerly also known as OS X feature: 📁 file provider macOS File Provider Extension, more general also known as virtual file system. labels Jun 26, 2026
@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 💻 Desktop Clients team Jun 26, 2026
@i2h3

i2h3 commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable-34.0

@i2h3 i2h3 moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 💻 Desktop Clients team Jun 26, 2026
@i2h3
i2h3 force-pushed the i2h3/funny-cerf-5f1fed branch from dc122af to 211f1a1 Compare June 26, 2026 09:41
@github-actions

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-10260.zip

Digest: sha256:8891dc34daedae8426dbf6ac8f27eaea6ba8d84c718527fada38841541cc9b6b

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@i2h3

i2h3 commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator Author

I still need to perform some manual tests.

@sonarqubecloud

Copy link
Copy Markdown

@i2h3
i2h3 merged commit 156e94b into master Jun 29, 2026
23 checks passed
@i2h3
i2h3 deleted the i2h3/funny-cerf-5f1fed branch June 29, 2026 07:29
@github-project-automation github-project-automation Bot moved this from 🏗️ In progress to ☑️ Done in 💻 Desktop Clients team Jun 29, 2026
@Mika-6-9

Copy link
Copy Markdown

Hello.
Sorry for the question, but why not make a more generic option to add lock monitoring for more files?
Example for AutoCAD:
A .dwg file is considered locked if .dwl and .dwl2 files exist.
This could be added to the user interface, similar to the feature for unsynchronized files.

@i2h3

i2h3 commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator Author

@Mika-6-9

Pro

  • More flexibility for end users to configure

Cons

  • Violates Nextcloud design principles of configuration minimization in favor of simplicity
  • While Adobe and (probably) AutoCAD have the predictable pattern by just creating another file with a different extension to indicate locking, the most popular and asked for third-party apps (in example Microsoft Office) do not and require logic to map the original file which is not trivial
  • Effort offloaded to end users
  • Requires end users to take action by themselves instead of shipping something out of the box
  • End users would be tempted to repeatedly configure themselves instead of reporting an issue for us to fix it once for everyone
  • Requires end users to have advanced knowledge about the apps they use far beyond the average (sometimes lock files are not even visible in file managers, so average people do not even know they exist)
  • Increases maintenance effort for us
  • Increases surface for bugs and regressions
  • Negatively impacts agility of the project because there are more minor side features to keep in mind (simplicity is a key factor to move fast which we have to with our little resources compared to Google LLC and others)
  • There is a reason why the major competitors do not offer that either
  • A user interface feature implementation which covers all platforms, Windows virtual files, macOS file provider and classic synchronization folders requires coordination and resources which also collide with other product and management interests and probably is simply not worth it for the little niche value it delivers
  • In my humble and personal opinion, we have too many features in the desktop client already. 😬 I prefer simplicity over feature bloat.

While we are on it, feel free to open a dedicated issue for the AutoCAD lock files, please! 😉 You can assign me directly.

@Mika-6-9

Mika-6-9 commented Jul 2, 2026

Copy link
Copy Markdown

Thank you very much for this detailed yet clear response.
I understand the points mentioned above, even though I would have preferred to be able to add file locks whenever I wanted, without needing custom development.
I have acted on your suggestion and created an issue: #10295
Thank you very much.

@mgallien mgallien modified the milestones: 34.0.0, 35.0.0 Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: 📁 file provider macOS File Provider Extension, more general also known as virtual file system. os: 🍎 macOS Apple macOS, formerly also known as OS X

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants