Port #10252 back manually to stable-33.0 - #10256
Merged
Merged
Conversation
…ogic Signed-off-by: Iva Horn <[email protected]> (cherry picked from commit dd22b8b)
…le-33.0 The SwiftPM test target did not compile on stable-33.0, independent of any single change, due to two partial-backport drifts: - MoveSafeDeletionTests used Enumerator.syncAnchor(at:), a helper introduced by the version-tagged sync anchor work (#10065) that was never backported to stable-33.0. Build the plain ISO8601 NSFileProviderSyncAnchor directly, as the other tests on this branch already do. - ItemPropertyTests' allowsExcludingFromSync test constructed an Item without the displayFileActions argument, which became a required Item.init parameter on stable-33.0; the other call sites pass it but this one was missed. Pass displayFileActions: false to match. No production code is affected. Full test target now builds and passes. Signed-off-by: Iva Horn <[email protected]> Co-Authored-By: Claude Opus 4.8 <[email protected]>
…ches The workflow only triggered on master, so for pull_request events (which use the base branch's workflow + branch filter) backport PRs targeting stable-* never ran the SwiftFormat lint or the xcodebuild test job. That is how partial backports left the stable-33.0 test target uncompilable behind green checks. Add the stable-* glob to both the push and pull_request branch filters so the kit is built and tested on stable branches too. Signed-off-by: Iva Horn <[email protected]> Co-Authored-By: Claude Opus 4.8 <[email protected]>
i2h3
force-pushed
the
backport/10252/stable-33.0
branch
from
June 26, 2026 07:03
4f5c82f to
55f39e2
Compare
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10256.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Checklist
AI (if applicable)