fix(gui): remove gap after status messages - #10245
Merged
Merged
Conversation
`option.rect` seems to be invalid on some platforms within `sizeHint`; e.g. on Linux it had a width of `-1`. This caused the text height to be calculated differently to `paint()` and a visual gap when a message is displayed. Signed-off-by: Jyrki Gadinger <[email protected]>
Member
Author
|
/backport to stable-34.0 please |
Member
Author
|
/backport to stable-33.0 please |
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10245.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
Rello
self-requested a review
June 24, 2026 13:48
Rello
approved these changes
Jun 24, 2026
|
This was referenced Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
option.rectseems to be invalid on some platforms withinsizeHint; e.g. on Linux it had a width of-1. This caused the text height to be calculated differently topaint()and a visual gap when a message is displayed.Resolves
#
Summary
TODO
Checklist
AI (if applicable)