Skip to content

Bugfix/end to end encryption - #10244

Merged
Rello merged 2 commits into
masterfrom
bugfix/endToEndEncryption
Jun 24, 2026
Merged

Bugfix/end to end encryption#10244
Rello merged 2 commits into
masterfrom
bugfix/endToEndEncryption

Conversation

@mgallien

@mgallien mgallien commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Resolves

#

Summary

TODO

  • ...

Checklist

AI (if applicable)

mgallien added 2 commits June 24, 2026 13:31
@mgallien
fix(encryption): explicit detection of child or root encrypted folders
4f35ed8 
ensure when building encrypted folder metadata that information about
its status (i.e. child folder or root folder) is set in arguments

when testing sharing and leaving shares, it got broken

Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien
fix(encryption): prevent user to leave encrypted shares: not possible
8b9d44b 
it is not possible currently to implement end-to-end encryption RFC and
allow an user to leave an encrypted share

removing all code that used to allow that

Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien mgallien added this to the 35.0.0 milestone Jun 24, 2026
@mgallien

mgallien commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable-34.0 please

@mgallien

mgallien commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable-33.0 please

@sonarqubecloud

sonarqubecloud Bot commented Jun 24, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
26.1% Coverage on New Code (required ≥ 80%)
D Security Rating on New Code (required ≥ A)
E Maintainability Rating on New Code (required ≥ A)
238 New Code Smells (required ≤ 0)
1 New Bugs (required ≤ 0)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-10244.zip

Digest: sha256:fd928779a5c352310beef6ccf3f3f7cd64c97d3d8ac73b7614582c80b7010201

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@Rello
Rello merged commit 2dd1193 into master Jun 24, 2026
22 of 24 checks passed
@Rello
Rello deleted the bugfix/endToEndEncryption branch June 24, 2026 16:38
This was referenced Jun 24, 2026
Merged
Merged
@mgallien

mgallien commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable-4.0 please

@backportbot backportbot Bot mentioned this pull request Jun 25, 2026
Merged
@mgallien

mgallien commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator Author

for reference nextcloud/end_to_end_encryption_rfc#76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nilsding nilsding nilsding approved these changes
@camilasan camilasan Awaiting requested review from camilasan camilasan is a code owner
@i2h3 i2h3 Awaiting requested review from i2h3 i2h3 is a code owner

Assignees

No one assigned

Labels

3. to review feature: 🔒 end to end encryption

Projects

None yet

Milestone

35.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mgallien @nilsding @Rello