Skip to content

[stable-4.0] fix(common): preserve Windows Explorer custom folder icons during migration. - #10131

Merged
mgallien merged 1 commit into
stable-4.0from
backport/9872/stable-4.0
Jun 9, 2026
Merged

[stable-4.0] fix(common): preserve Windows Explorer custom folder icons during migration.#10131
mgallien merged 1 commit into
stable-4.0from
backport/9872/stable-4.0

Conversation

@backportbot

@backportbot backportbot Bot commented Jun 9, 2026

Copy link
Copy Markdown

Backport of PR #9872

…ration.

Check the encoding of the Desktop.ini file to determine if it should be
overwritten or preserved:
- Windows Explorer writes Desktop.ini in UTF-16LE (custom icon),
- While the client always writes UTF-8 (default icon).

Fixes the regression introduced by d60c760.

Signed-off-by: Camila Ayres <[email protected]>
@backportbot
backportbot Bot requested review from Aiiaiiio, camilasan and i2h3 as code owners June 9, 2026 13:00
@backportbot
backportbot Bot requested a review from mgallien June 9, 2026 13:00
@backportbot
backportbot Bot requested review from mgallien and nilsding as code owners June 9, 2026 13:00
@backportbot backportbot Bot added this to the 4.0.11 milestone Jun 9, 2026
@mgallien
mgallien enabled auto-merge June 9, 2026 13:22
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-10131.zip

Digest: sha256:f3f5dd9e1d7364154dc1ce616cbdb2c642ae95eb4e3b5d19135eac2cc1850dc3

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien
mgallien merged commit 003e017 into stable-4.0 Jun 9, 2026
19 checks passed
@mgallien
mgallien deleted the backport/9872/stable-4.0 branch June 9, 2026 13:58
@sonarqubecloud

sonarqubecloud Bot commented Jun 9, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants