Skip to content

fix: evaluate notify-push ids and only start sync if the ids are know - #10104

Merged
Rello merged 3 commits into
masterfrom
feature/fileProviderNotifyPush
Jun 4, 2026
Merged

fix: evaluate notify-push ids and only start sync if the ids are know#10104
Rello merged 3 commits into
masterfrom
feature/fileProviderNotifyPush

Conversation

@Rello

@Rello Rello commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

evaluate notify-push ids and only start sync if the ids are known/enumerated at all

Bildschirmfoto 2026-06-03 um 11 19 18

@Rello
Rello marked this pull request as ready for review June 3, 2026 19:21

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0b485d7ff2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/gui/macOS/fileproviderdomainmanager.mm
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-10104.zip

Digest: sha256:145ae708c6c6883398137b51018fec779cb78b132cf6dbf420b1b13600c72305

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud

sonarqubecloud Bot commented Jun 4, 2026

Copy link
Copy Markdown

@i2h3 i2h3 assigned i2h3 and Rello and unassigned i2h3 Jun 4, 2026
@i2h3 i2h3 added os: 🍎 macOS Apple macOS, formerly also known as OS X feature: 📁 file provider macOS File Provider Extension, more general also known as virtual file system. labels Jun 4, 2026
@i2h3 i2h3 modified the milestones: 34.0.0, 33.0.6 Jun 4, 2026
@Rello
Rello merged commit 66bc98c into master Jun 4, 2026
22 of 23 checks passed
@Rello
Rello deleted the feature/fileProviderNotifyPush branch June 4, 2026 07:38
@nilsding

Copy link
Copy Markdown
Member

/backport to stable-33.0 please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: 📁 file provider macOS File Provider Extension, more general also known as virtual file system. os: 🍎 macOS Apple macOS, formerly also known as OS X

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants