Skip to content

Fix: Make color picker keyboard-focusable#7446

Merged
luka-nextcloud merged 1 commit intonextcloud:mainfrom
theoholl:fix-color-picker-not-focusable
Dec 18, 2025
Merged

Fix: Make color picker keyboard-focusable#7446
luka-nextcloud merged 1 commit intonextcloud:mainfrom
theoholl:fix-color-picker-not-focusable

Conversation

@theoholl
Copy link
Copy Markdown
Contributor

Summary

The color picker used a div element as the open button which can normally not be focused. I replaced the div with a native button and adjusted the styling so that the button stays round.

Screencast.Fix.mp4

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@luka-nextcloud
Copy link
Copy Markdown
Contributor

@theoholl Could you resolve merge conflicts?

@theoholl
Copy link
Copy Markdown
Contributor Author

@theoholl Could you resolve merge conflicts?

@luka-nextcloud Done.

@luka-nextcloud
Copy link
Copy Markdown
Contributor

@theoholl Thanks, it would be awesome if you could squash your commits into one.

@juliusknorr
Copy link
Copy Markdown
Member

To clarify a bit more, it would need a rebase of this change so that there is no extra merge commits in the commit history. Let us know if you have any questions around that.

@theoholl theoholl force-pushed the fix-color-picker-not-focusable branch from d79ea7d to 19c829c Compare December 18, 2025 10:32
@theoholl
Copy link
Copy Markdown
Contributor Author

@luka-nextcloud makes sense :) Should be OK now?

@luka-nextcloud
Copy link
Copy Markdown
Contributor

It looks good, thanks!

@luka-nextcloud
Copy link
Copy Markdown
Contributor

/backport to stable31

@luka-nextcloud
Copy link
Copy Markdown
Contributor

/backport to stable32

@luka-nextcloud luka-nextcloud merged commit a7c4326 into nextcloud:main Dec 18, 2025
31 of 37 checks passed
@backportbot
Copy link
Copy Markdown

backportbot bot commented Dec 18, 2025

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/7446/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 19c829c6

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7446/stable32

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress
fatal: cherry-pick failed


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
Copy link
Copy Markdown

backportbot bot commented Dec 18, 2025

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/7446/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 19c829c6

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7446/stable31

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress
fatal: cherry-pick failed


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@github-actions
Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Color picker for board color cannot be focused by keyboard

3 participants