fix(comment): improve comment form behavior in firefox#7397
Merged
luka-nextcloud merged 1 commit intomainfrom Nov 27, 2025
Merged
fix(comment): improve comment form behavior in firefox#7397luka-nextcloud merged 1 commit intomainfrom
luka-nextcloud merged 1 commit intomainfrom
Conversation
juliusknorr
approved these changes
Nov 25, 2025
Member
juliusknorr
left a comment
There was a problem hiding this comment.
We could actually switch to https://nextcloud-vue-components.netlify.app/#/Components/NcRichContenteditable these days to not have our own at.js wrapping.
But fine with me as a bug fix 👍
Contributor
Author
|
@juliusknorr Sounds reasonable :) I will update the PR. |
3dc7924 to
6ebebaf
Compare
juliusknorr
reviewed
Nov 27, 2025
juliusknorr
reviewed
Nov 27, 2025
Member
juliusknorr
left a comment
There was a problem hiding this comment.
Thanks for adjusting, one more commend and I think the styling also can get some cleanup. Not sure we still need the .atwho-wrap rules
Signed-off-by: Luka Trovic <[email protected]>
6ebebaf to
eb401ff
Compare
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
This was referenced Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix for Firefox where clicking on/after a mention in card comment input
Checklist