Skip to content

fix(comment): improve comment form behavior in firefox#7397

Merged
luka-nextcloud merged 1 commit intomainfrom
fix-comment-form-on-firefox
Nov 27, 2025
Merged

fix(comment): improve comment form behavior in firefox#7397
luka-nextcloud merged 1 commit intomainfrom
fix-comment-form-on-firefox

Conversation

@luka-nextcloud
Copy link
Copy Markdown
Contributor

@luka-nextcloud luka-nextcloud commented Nov 25, 2025

Summary

Fix for Firefox where clicking on/after a mention in card comment input

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Nov 25, 2025
@luka-nextcloud luka-nextcloud moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team Nov 25, 2025
Copy link
Copy Markdown
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could actually switch to https://nextcloud-vue-components.netlify.app/#/Components/NcRichContenteditable these days to not have our own at.js wrapping.

But fine with me as a bug fix 👍

@luka-nextcloud
Copy link
Copy Markdown
Contributor Author

@juliusknorr Sounds reasonable :) I will update the PR.

@luka-nextcloud luka-nextcloud force-pushed the fix-comment-form-on-firefox branch from 3dc7924 to 6ebebaf Compare November 27, 2025 09:34
Copy link
Copy Markdown
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adjusting, one more commend and I think the styling also can get some cleanup. Not sure we still need the .atwho-wrap rules

@luka-nextcloud luka-nextcloud force-pushed the fix-comment-form-on-firefox branch from 6ebebaf to eb401ff Compare November 27, 2025 10:05
@luka-nextcloud
Copy link
Copy Markdown
Contributor Author

/backport to stable32

@luka-nextcloud
Copy link
Copy Markdown
Contributor Author

/backport to stable31

@luka-nextcloud luka-nextcloud merged commit db93f1b into main Nov 27, 2025
34 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ☑️ Done in 📝 Productivity team Nov 27, 2025
@luka-nextcloud luka-nextcloud deleted the fix-comment-form-on-firefox branch November 27, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[Bug] comment input ignored key input after user mention

2 participants