fix: translation for recently contacted not working#4662
Merged
Conversation
The contactsinteraction translations are not loaded in the contacts app hence the source string is never translated. Signed-off-by: Daniel Kesselberg <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4662 +/- ##
=======================================
Coverage 9.71% 9.71%
Complexity 266 266
=======================================
Files 126 126
Lines 6330 6330
Branches 1184 1184
=======================================
Hits 615 615
Misses 5594 5594
Partials 121 121 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GVodyanov
approved these changes
Aug 29, 2025
Contributor
Author
|
/backport to stable7.3 |
Contributor
Author
|
/backport to stable6.0 |
Contributor
Author
|
/backport to stable8.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came across this issue while working on a related case with a user who was using Nextcloud in different languages.
The
contactsinteractiontranslations are not loaded in the Contacts app, so the source string is never translated. It’s just a detail, but it would look nicer if the menu item were shown correctly.How to reproduce:
[email protected]Note:
There will be a follow-up for contacts and server removing the translation, but this will take some more time. As this change is small, we can easily backport it to all supported versions.