Import file FileAction 28 compatibility by GretaD · Pull Request #3669 · nextcloud/contacts

GretaD · 2023-10-18T10:55:42Z

Add initi.ts file
addInitScript on LoadContactsFilesActions.php
Migrate files-action.js to the new api
Check documentation how to migrate OCA.Files.fileActions.setDefault(mime, name)

codecov · 2023-10-18T11:14:17Z

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (75f294f) 2.07% compared to head (bb0e8ae) 0.00%.
Report is 20 commits behind head on main.

❗ Current head bb0e8ae differs from pull request most recent head 5493404. Consider uploading reports for the commit 5493404 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##              main   #3669      +/-   ##
==========================================
- Coverage     2.07%   0.00%   -2.08%     
- Complexity       0     261     +261     
==========================================
  Files           89      24      -65     
  Lines         5343     784    -4559     
  Branches      1491       0    -1491     
==========================================
- Hits           111       0     -111     
+ Misses        5114     784    -4330     
+ Partials       118       0     -118

Files	Coverage Δ
lib/Listener/LoadContactsFilesActions.php	`0.00% <0.00%> (ø)`

... and 112 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/files-action.js

lib/Listener/LoadContactsFilesActions.php

src/files-action.js

src/init.d.ts

lib/Listener/LoadContactsFilesActions.php

src/files-action.js

.jshintrc

st3iny

I tested it and it works no master and stable27. Please address the feedback regarding jshint.

st3iny

Tested and works. I fixed some minor bugs and merged both if statements.

Please squash all commits and we are ready to merge :)

Feedback was addressed.

Signed-off-by: greta <[email protected]>

skjnldsv · 2023-11-03T08:35:04Z

lib/Listener/LoadContactsFilesActions.php

+		if (method_exists(Util::class, 'addInitScript')) {
+			Util::addInitScript(Application::APP_ID, 'contacts-files-action');
+		} else {
+			Util::addScript(Application::APP_ID, 'contacts-files-action');


Suggested change

Util::addScript(Application::APP_ID, 'contacts-files-action');

Util::addScript(Application::APP_ID, 'contacts-files-action', 'files');

skjnldsv · 2023-11-03T08:36:08Z

src/files-action.js

-	}
-	console.error('Unable to register vcf import action')
-})
+if (nextcloudVersionIsGreaterThanOr28) {


I am not even sure this is needed. Worse case this will register an unused action 🤷

skjnldsv · 2023-11-03T08:38:32Z

src/files-action.js

+		id: name,
+		displayName: () => t('contacts', 'Import'),
+		default: DefaultType.DEFAULT,
+		mime,


FileAction doesn't have a mime

skjnldsv · 2023-11-03T08:40:23Z

src/files-action.js

+		default: DefaultType.DEFAULT,
+		mime,
+		enabled: (nodes) => {
+			return nodes.every((node) => node.mime === mime && (node.permissions & Permission.READ))


Using some with the opposite check is faster as it fill stop at the first false return
Something like

Suggested change

return nodes.every((node) => node.mime === mime && (node.permissions & Permission.READ))

return nodes.some((node) => node.mime !== mime || (node.permissions & Permission.READ) === 0)

skjnldsv · 2023-11-03T08:41:05Z

Added some comments @GretaD @st3iny

GretaD added the 2. developing Work in progress label Oct 18, 2023

GretaD self-assigned this Oct 18, 2023

GretaD marked this pull request as draft October 18, 2023 10:55

GretaD requested a review from skjnldsv October 19, 2023 13:48

GretaD commented Oct 19, 2023

View reviewed changes

src/files-action.js Outdated Show resolved Hide resolved

GretaD force-pushed the migrate/contacts-newfile-api branch from 3b66493 to 809e787 Compare October 25, 2023 08:01

skjnldsv removed their request for review October 25, 2023 08:32

GretaD requested a review from ChristophWurst October 25, 2023 12:54

GretaD added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 25, 2023

GretaD marked this pull request as ready for review October 25, 2023 12:54

ChristophWurst reviewed Oct 25, 2023

View reviewed changes

GretaD commented Oct 26, 2023

View reviewed changes

src/init.d.ts Outdated Show resolved Hide resolved

GretaD requested review from ChristophWurst and st3iny October 26, 2023 14:05

st3iny reviewed Oct 26, 2023

View reviewed changes

lib/Listener/LoadContactsFilesActions.php Show resolved Hide resolved

GretaD requested a review from st3iny October 27, 2023 12:48

ChristophWurst previously requested changes Oct 31, 2023

View reviewed changes

src/files-action.js Outdated Show resolved Hide resolved

GretaD requested a review from ChristophWurst October 31, 2023 14:47

ChristophWurst reviewed Oct 31, 2023

View reviewed changes

.jshintrc Outdated Show resolved Hide resolved

st3iny reviewed Nov 1, 2023

View reviewed changes

GretaD requested a review from st3iny November 1, 2023 10:29

st3iny approved these changes Nov 1, 2023

View reviewed changes

st3iny added 4. to release Ready to be released and/or waiting for tests to finish technical debt and removed 3. to review Waiting for reviews labels Nov 1, 2023

st3iny added this to the v5.5.0 milestone Nov 1, 2023

Import file FileAction 28 compatibility

5493404

Signed-off-by: greta <[email protected]>

GretaD force-pushed the migrate/contacts-newfile-api branch from 20b4bee to 5493404 Compare November 1, 2023 15:24

GretaD enabled auto-merge November 1, 2023 15:24

GretaD merged commit 6cd8952 into main Nov 1, 2023

GretaD deleted the migrate/contacts-newfile-api branch November 1, 2023 15:30

skjnldsv reviewed Nov 3, 2023

View reviewed changes

GretaD mentioned this pull request Nov 3, 2023

Fix the permission check on files-actions #3690

Merged

joshtrichards mentioned this pull request Feb 1, 2024

[Bug]: Files Plugin Register does not work in stable28 nextcloud/server#43265

Closed

8 tasks

	Util::addScript(Application::APP_ID, 'contacts-files-action');
	Util::addScript(Application::APP_ID, 'contacts-files-action', 'files');

	return nodes.every((node) => node.mime === mime && (node.permissions & Permission.READ))
	return nodes.some((node) => node.mime !== mime \|\| (node.permissions & Permission.READ) === 0)

Comments

Conversation

GretaD commented Oct 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Oct 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

st3iny left a comment

Choose a reason for hiding this comment

Uh oh!

st3iny left a comment

Choose a reason for hiding this comment

Uh oh!

skjnldsv Nov 3, 2023

Choose a reason for hiding this comment

Uh oh!

skjnldsv Nov 3, 2023

Choose a reason for hiding this comment

Uh oh!

skjnldsv Nov 3, 2023

Choose a reason for hiding this comment

Uh oh!

skjnldsv Nov 3, 2023

Choose a reason for hiding this comment

Uh oh!

skjnldsv commented Nov 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

GretaD commented Oct 18, 2023 •

edited

Loading

codecov bot commented Oct 18, 2023 •

edited

Loading