fix(contacts): display name not uri for recent-contacted address book#3339
Merged
ChristophWurst merged 1 commit intomainfrom Apr 26, 2023
Merged
Conversation
Comment on lines
101
to
103
| return this.options. | ||
| filter(option => option.readOnly === undefined || !option.readOnly). | ||
| map(addressbook => { |
Member
There was a problem hiding this comment.
Suggested change
| return this.options. | |
| filter(option => option.readOnly === undefined || !option.readOnly). | |
| map(addressbook => { | |
| return this.options | |
| .filter(option => option.readOnly === undefined || !option.readOnly). | |
| .map(addressbook => { |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3339 +/- ##
==========================================
- Coverage 1.86% 0.00% -1.87%
Complexity 272 272
==========================================
Files 112 25 -87
Lines 5963 824 -5139
Branches 1401 0 -1401
==========================================
- Hits 111 0 -111
+ Misses 5738 824 -4914
+ Partials 114 0 -114 ☔ View full report in Codecov by Sentry. |
Member
main
fix/2187/raw-recent-contacted-uri-visible default state
fix/2187/raw-recent-contacted-uri-visible focus state
|
JohannesGGE
added
2. developing
Contributor
Author
|
@ChristophWurst This seems to be a generel bug with the PropertySelect component because the isReadOnly is not passed, so it's always false. |
JohannesGGE
added
3. to review
st3iny
approved these changes
Apr 26, 2023
| */ | ||
| selectableOptions() { | ||
| return this.options | ||
| .filter(option => option.readOnly === undefined || !option.readOnly) |
Member
There was a problem hiding this comment.
Suggested change
| .filter(option => option.readOnly === undefined || !option.readOnly) | |
| .filter(option => !option.readOnly) |
Could be simplified.
Comment on lines
497
to
506
| addressbooksOptions() { | ||
| return this.addressbooks | ||
| .filter(addressbook => !addressbook.readOnly && addressbook.enabled) | ||
| .filter(addressbook => addressbook.enabled) | ||
| .map(addressbook => { | ||
| return { | ||
| id: addressbook.id, | ||
| name: addressbook.displayName, | ||
| readOnly: addressbook.readOnly, | ||
| } | ||
| }) |
Member
There was a problem hiding this comment.
This could have side effects. However, I did not spot any during my testing and the address book options made sense.
Signed-off-by: Johannes Merkel <[email protected]>
JohannesGGE
force-pushed
the
fix/2187/raw-recent-contacted-uri-visible
branch
from
9e75e67 to
6421bd4
Compare
ChristophWurst
approved these changes
Apr 26, 2023
Contributor
Author
|
/backport to stable5.2 |
Contributor
Author
|
/backport to stable4.2 |
This was referenced Apr 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #2187