Fix Don't show groups in share placeholder if group sharing is disabled #2242#2419
Merged
ChristophWurst merged 1 commit intonextcloud:mainfrom May 22, 2023
Merged
Conversation
Zishan-7
force-pushed
the
group-share-enable-placeholder
branch
from
c127cd3 to
b396367
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2419 +/- ##
==========================================
- Coverage 1.82% 0.00% -1.83%
Complexity 272 272
==========================================
Files 112 25 -87
Lines 6091 826 -5265
Branches 1450 0 -1450
==========================================
- Hits 111 0 -111
+ Misses 5865 826 -5039
+ Partials 115 0 -115
☔ View full report in Codecov by Sentry. |
skjnldsv
reviewed
Aug 30, 2021
Zishan-7
force-pushed
the
group-share-enable-placeholder
branch
from
87e8fd9 to
0810531
Compare
ChristophWurst
force-pushed
the
group-share-enable-placeholder
branch
from
0810531 to
092dc56
Compare
ChristophWurst
added
4. to release
nextcloud#2242 Signed-off-by: Zishan-7 <[email protected]>
hamza221
force-pushed
the
group-share-enable-placeholder
branch
from
092dc56 to
fb0709f
Compare
Contributor
|
Fixed lint check, and rebased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2242 by checking group sharing enabled or not then updating the value of placeholder based on that value