Merged
Conversation
Member
|
Yes. You do. |
ghost
mentioned this pull request
This was referenced Apr 12, 2018
This was referenced Jul 24, 2018
sleepypioneer
pushed a commit
that referenced
this pull request
Aug 9, 2018
Closed
ghost
mentioned this pull request
This was referenced Oct 12, 2020
This was referenced Oct 29, 2020
This was referenced Nov 3, 2020
This was referenced Dec 11, 2020
kesselb
added a commit
that referenced
this pull request
Jan 6, 2023
Motivation to scope PHPUnit is the removal of PHP 7.4 support. With config.platform.php = 8.0 composer will install a newer PHPUnit stack. phpunit/php-code-coverage require at least nikic/php-parser 1.14 but 3rdparty nikic/php-parser is 1.10.5. The incompatible installations cause the coverage run to fail: SebastianBergmann\CodeCoverage\StaticAnalysis\CodeUnitFindingVisitor::unionOrIntersectionAsString(): Argument #1 ($type) must be of type PhpParser\Node\ComplexType, PhpParser\Node\UnionType given, called in /home/runner/work/contacts/contacts/apps/contacts/vendor/phpunit/php-code-coverage/src/StaticAnalysis/CodeUnitFindingVisitor.php on line 184 Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
added a commit
that referenced
this pull request
Jan 6, 2023
Motivation to scope PHPUnit is the removal of PHP 7.4 support. With config.platform.php = 8.0 composer will install a newer PHPUnit stack. phpunit/php-code-coverage require at least nikic/php-parser 1.14 but 3rdparty nikic/php-parser is 1.10.5. The incompatible installations cause the coverage run to fail: SebastianBergmann\CodeCoverage\StaticAnalysis\CodeUnitFindingVisitor::unionOrIntersectionAsString(): Argument #1 ($type) must be of type PhpParser\Node\ComplexType, PhpParser\Node\UnionType given, called in /home/runner/work/contacts/contacts/apps/contacts/vendor/phpunit/php-code-coverage/src/StaticAnalysis/CodeUnitFindingVisitor.php on line 184 Signed-off-by: Daniel Kesselberg <[email protected]>
Closed
kesselb
added a commit
that referenced
this pull request
Jan 6, 2023
Motivation to scope PHPUnit is the removal of PHP 7.4 support. With config.platform.php = 8.0 composer will install a newer PHPUnit stack. phpunit/php-code-coverage require at least nikic/php-parser 1.14 but 3rdparty nikic/php-parser is 1.10.5. The incompatible installations cause the coverage run to fail: `SebastianBergmann\CodeCoverage\StaticAnalysis\CodeUnitFindingVisitor::unionOrIntersectionAsString(): Argument #1 ($type) must be of type PhpParser\Node\ComplexType, PhpParser\Node\UnionType given, called in /home/runner/work/contacts/contacts/apps/contacts/vendor/phpunit/php-code-coverage/src/StaticAnalysis/CodeUnitFindingVisitor.php on line 184` Signed-off-by: Daniel Kesselberg <[email protected]>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.