Conversation
Signed-off-by: dartcafe <[email protected]>
dartcafe
force-pushed
the
php-cs-fixer-3
branch
from
89c3aeb to
8a61acc
Compare
Signed-off-by: dartcafe <[email protected]>
dartcafe
force-pushed
the
php-cs-fixer-3
branch
from
fb76775 to
8f65365
Compare
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Thanks a lot. Will give this a test soon :)
Signed-off-by: dartcafe <[email protected]>
ChristophWurst
approved these changes
Nov 10, 2021
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Tested with Mail and works 🚀 
Comment on lines
-42
to
-44
| 'list_syntax' => [ | ||
| 'syntax' => 'short', | ||
| ], |
Member
There was a problem hiding this comment.
was this intentional? It's this here, right:
list($a, $b) = …;
[$a, $b] = …;I don't think we want to go back and allow the long one?
Member
There was a problem hiding this comment.
I didn't catch this but no, I would not go back. Could you send a PR to fix it? We can do a v1.0.1
Member
There was a problem hiding this comment.
Or is this rule not supported anymore and "short" by default now?
Contributor
Author
There was a problem hiding this comment.
I removed it, because it is declared as default in 3.2.
Changed default values of options
| Rule | Option | Old value | New value |
|---|---|---|---|
list_syntax |
syntax |
'long' |
'short' |
Contributor
Author
There was a problem hiding this comment.
Good to know, that someone does a real review...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first try
fixes #6
Since v3 brings some breaking changes, I guess, it should be a major version update.
Also some remarks are recommended:
.gitignore:.php-cs-fixer.cache