Remove circle name from share's recipient's e-mail notification#1422
Remove circle name from share's recipient's e-mail notification#1422Jerome-Herbinet wants to merge 1 commit intomasterfrom
Conversation
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
|
While I like the idea, the result might not be the expected one, the sentence itself needs some change |
@ArtificialOwl could you help me by giving some more information about the needed changes ? |
|
maybe ending the sentence by "with you" ? instead of "with (empty)" |
|
To keep the discussion in one place, let’s maybe continue in the issue where I posted a suggestion already: #1239 (comment) |
Signed-off-by: Jérôme Herbinet <[email protected]> Remove circle name from share's recipient's e-mail notification Signed-off-by: Jérôme Herbinet <[email protected]>
Jerome-Herbinet
force-pushed
the
Jerome-Herbinet-remove-circle-name-from-recipient-notification
branch
from
e4cc5b0 to
5fb7ac3
Compare
|
Check last commit, following discussion with @jancborchardt in #1239 |
|
@Jerome-Herbinet neither @skjnldsv nor I am maintainers of this app. |
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
@Jerome-Herbinet as you outlined in your comment at #1239 (comment) – this seems to go beyond a simple wording change.
Currrently you will know that you are part of a team, by just checking in Contacts for example. For this wording change to make sense, a functionality change would have to go hand in hand. Whether that is something we would like is a different discussion.
But thus I would at least propose to close this pull request since just on its own it can seem misleading. Would that be ok?
jancborchardt
deleted the
Jerome-Herbinet-remove-circle-name-from-recipient-notification
branch
5 participants
May ...
Fix: #1239
Not sure if it's enough and correct from a syntax point of view ; I would need reviewers to test it by their side.
The goal is just to remove the circle's name from the e-mail that the recipient receives because circle's name is not his business and should be kept private.
Thanks