Conversation
Closes nextcloud/calendar#3551 Signed-off-by: Thomas Citharel <[email protected]>
tcitworld
added
3. to review
ChristophWurst
approved these changes
Oct 28, 2021
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Package lock update is unrelated but I'm fine with it
st3iny
approved these changes
Nov 2, 2021
Member
st3iny
left a comment
st3iny
left a comment
There was a problem hiding this comment.
LGTM! Updating the package lock has to be done sooner or later anyways. I'd leave it in a separate commit (like it currently is).
Member
|
conflicts 🤐 |
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Thomas Citharel <[email protected]> Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
force-pushed
the
fix-undefined-content-type
branch
from
c147ea2 to
64db998
Compare
Member
|
I moved the package log upgrade to a separate PR. I didn't change anything else. |
Member
I reopened nextcloud/calendar#3551 since it got closed automatically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thought it would fix nextcloud/calendar#3551 but it doesn't.
Still, wouldn't hurt.