fix(editor): don't respect default calendar in the calendar picker#5996
Merged
fix(editor): don't respect default calendar in the calendar picker#5996
Conversation
The default calendar URL from the backend is more restrictive as it is primarily meant for incoming invitations. This commit effectively reverts the editor's calendar picker default choice to how it behaved before v4.7.0. Signed-off-by: Richard Steinmetz <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5996 +/- ##
=========================================
Coverage 23.51% 23.51%
Complexity 455 455
=========================================
Files 246 246
Lines 11722 11718 -4
Branches 2156 2154 -2
=========================================
Hits 2756 2756
+ Misses 8650 8647 -3
+ Partials 316 315 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
st3iny
force-pushed
the
fix/editor/ignore-default-calendar
branch
from
f570da1 to
4f2caf6
Compare
Member
Author
|
Backport is tricky due to translation changes. |
ChristophWurst
approved these changes
May 10, 2024
2 tasks
Member
|
For calendar power users, it is inconvenient to select a calendar every time or it is easy to forget. @st3iny fyi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #5942
Partially reverts #5790
The default calendar URL from the backend is more restrictive as it is primarily meant for incoming invitations. This commit effectively reverts the editor's calendar picker default choice to how it behaved before v4.7.0.
As discussed in a meeting with Christoph.