fix: don't apply default calendar on Nextcloud < 29#5980
Merged
Conversation
The feature to set the default calendar is only available in Nextcloud >= 29 so users might be confused by the default calendar choice which they can't influence. Signed-off-by: Richard Steinmetz <[email protected]>
Member
Author
|
/backport to stable4.7 |
backportbot
bot
added
the
backport-request
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5980 +/- ##
============================================
- Coverage 23.52% 23.51% -0.01%
Complexity 455 455
============================================
Files 246 246
Lines 11716 11718 +2
Branches 2144 2155 +11
============================================
Hits 2756 2756
Misses 8646 8646
- Partials 314 316 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tcitworld
approved these changes
May 3, 2024
backportbot
bot
removed
the
backport-request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5942
The feature to set the default calendar is only available in Nextcloud >= 29 so users might be confused by the default calendar choice which they can't influence.
Simply use the old logic (first sorted calendar) on older instances.