Hide sharing calendar via link in UI when sharing via link is disabled#4572
Hide sharing calendar via link in UI when sharing via link is disabled#4572pboguslawski wants to merge 1 commit intonextcloud:mainfrom
Conversation
This mod hides sharing calendar via link in UI when `shareapi_allow_links` is disabled. Should be applied together with nextcloud/server#34372 Related: nextcloud/server#34372 Related: nextcloud#525 Related: nextcloud#4399 Author-Change-Id: IB#1126264 Signed-off-by: Pawel Boguslawski <[email protected]>
tcitworld
left a comment
tcitworld
left a comment
There was a problem hiding this comment.
You don't need this at all. :)
calendar.canBePublished will be false since it depends on the DAV property
cs:allowed-sharing-modes, which is set by
https://github.com/nextcloud/server/blob/905753be42af7e8c5af304b0d3c93f5d9bcea789/apps/dav/lib/CalDAV/Publishing/PublishPlugin.php#L138
As long as the plugin is unregistered, the value won't be set anymore.
(ref nextcloud/server#34372 (comment))
|
This mod is not required when nextcloud/server#34372 is merged. Thanks for pointing this optimization! |
Seems this solution is wrong because unregistering plugin like in nextcloud/server@bfd8c62 disables also possibility to share calendar with other nc users (hidden share icon and user/group list, not just "share via link" option under share menu; this PR is about disabling sharing via link only). Let us know if you see better solution or we'll return to the original proposition. |
3 participants
This mod hides sharing calendar via link in UI when
shareapi_allow_linksis disabled. Should be applied together with nextcloud/server#34372Related: nextcloud/server#34372
Related: #525
Related: #4399
Author-Change-Id: IB#1126264
Signed-off-by: Pawel Boguslawski [email protected]