Merged
Conversation
| // loop to update every child | ||
| for (int i = 1; i < remoteData.getResponses().length; ++i) { | ||
| we = new WebdavEntry(remoteData.getResponses()[i], splitElement); | ||
| versions.add(new FileVersion(fileId, we)); |
Member
There was a problem hiding this comment.
we as a variable isn't needed and could be dropped since it is needed only for the versions.add call
| Log_OC.e(TAG, "Synchronized with id " + fileId + ": " + result.getLogMessage(), | ||
| result.getException()); | ||
| } else { | ||
| Log_OC.e(TAG, "Synchronized with id " + fileId + ": " + result.getLogMessage()); |
Member
There was a problem hiding this comment.
shouldn't this rather be a warning then? I can also live with error though.
Member
|
👍 just some minor comments |
tobiasKaminsky
force-pushed
the
fileVersioning
branch
from
d2f2576 to
1a624ee
Compare
Member
Author
|
Changed & rebased |
Member
|
@tobiasKaminsky can't test, your Nc14 instance seems broken as in the server code might need updating: |
tobiasKaminsky
force-pushed
the
fileVersioning
branch
from
a2d74fd to
3be5ed4
Compare
Signed-off-by: tobiasKaminsky <[email protected]>
Signed-off-by: tobiasKaminsky <[email protected]>
Signed-off-by: tobiasKaminsky <[email protected]>
AndyScherzinger
force-pushed
the
fileVersioning
branch
from
3be5ed4 to
f325385
Compare
Member
|
Sorry @mario totally forgot about this one :( |
Member
|
I tested it and it works |
3 tasks
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to fetch file versions.
Signed-off-by: tobiasKaminsky [email protected]