Skip to content

Comments

Fix: ImageActivity crash after options menu selected#12226

Merged
AndyScherzinger merged 1 commit intomasterfrom
fix-options-menu
Dec 6, 2023
Merged

Fix: ImageActivity crash after options menu selected#12226
AndyScherzinger merged 1 commit intomasterfrom
fix-options-menu

Conversation

@parneet-guraya
Copy link
Contributor

@parneet-guraya parneet-guraya commented Dec 4, 2023

Before

Record_2023-12-04-13-58-18.mp4

After

Record_2023-12-04-13-59-13.mp4
  • Tests written, or not not needed

@alperozturk96
Copy link
Collaborator

alperozturk96 commented Dec 5, 2023

/rebase

@alperozturk96 alperozturk96 mentioned this pull request Dec 6, 2023
Merged
1 task
@alperozturk96
Copy link
Collaborator

alperozturk96 commented Dec 6, 2023

/backport to stable-3.27

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.28.0 milestone Dec 6, 2023
@github-actions
Copy link

github-actions bot commented Dec 6, 2023

Codacy

Lint

TypemasterPR
Warnings7575
Errors99

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness6969
Dodgy code359359
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5858
Security1818
Total552552

@github-actions
Copy link

github-actions bot commented Dec 6, 2023

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12226.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@AndyScherzinger AndyScherzinger merged commit 2b166a8 into master Dec 6, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-options-menu branch December 6, 2023 18:37
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 6, 2023
Merged
@github-actions
Copy link

github-actions bot commented Apr 1, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonasMayerDev JonasMayerDev JonasMayerDev approved these changes

@alperozturk96 alperozturk96 alperozturk96 approved these changes

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

Assignees

No one assigned

Labels

4. to release feedback-requested

Projects

None yet

Milestone

Nextcloud App 3.28.0

Development

Successfully merging this pull request may close these issues.

4 participants

@parneet-guraya @alperozturk96 @JonasMayerDev @AndyScherzinger