Avoid full folder refresh during onBrowseUp#10688
Merged
AlvaroBrey merged 1 commit intomasterfrom Sep 2, 2022
Merged
Conversation
Signed-off-by: Dariusz Olszewski <[email protected]>
starypatyk
added
3. to review
performance: misc
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10688.apk |
Codecov Report
@@ Coverage Diff @@
## master #10688 +/- ##
=============================================
+ Coverage 3.28% 31.52% +28.24%
- Complexity 428 3310 +2882
=============================================
Files 539 539
Lines 40228 40230 +2
Branches 5556 5557 +1
=============================================
+ Hits 1322 12684 +11362
+ Misses 38823 25641 -13182
- Partials 83 1905 +1822
|
Member
|
I think this is fine. |
tobiasKaminsky
approved these changes
Sep 2, 2022
delete-merged-branch
bot
deleted the
fix/noid/no_full_refresh_on_browse_up
branch
Member
|
Thanks @starypatyk ! |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have noticed that during going up in the folder hierarchy the folder gets refreshed longer than expected.
It turns out that during execution of com.owncloud.android.ui.fragment.OCFileListFragment.onBrowseUp, a full refresh is requested (with ignoreETag set to true).
Is this the expected behaviour?
If not - this PR is an attempt to fix it, but I am not sure if this is a correct way (in current code value of ignoreETag is lost between ExtendedListFragment.onRefresh and FileDisplayActivity.onRefresh).
Thoughts?