Skip to content

Commit b8b620b

Browse files
Merge 64dbe41 into 2c5f60f
2 parents 2c5f60f + 64dbe41 commit b8b620b

2 files changed

Lines changed: 8 additions & 4 deletions

File tree

lib/MailQueueHandler.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -148,11 +148,11 @@ protected function getAffectedUsers(?int $limit, int $latestSend, bool $forceSen
148148

149149
if ($restrictEmails !== null) {
150150
if ($restrictEmails === UserSettings::EMAIL_SEND_HOURLY) {
151-
$query->where($query->expr()->eq('amq_timestamp', $query->func()->subtract('amq_latest_send', $query->expr()->literal(3600))));
151+
$query->where($query->expr()->eq('amq_timestamp', $query->func()->subtract('amq_latest_send', $query->expr()->literal(UserSettings::BATCH_TIME_HOURLY))));
152152
} elseif ($restrictEmails === UserSettings::EMAIL_SEND_DAILY) {
153-
$query->where($query->expr()->eq('amq_timestamp', $query->func()->subtract('amq_latest_send', $query->expr()->literal(3600 * 24))));
153+
$query->where($query->expr()->eq('amq_timestamp', $query->func()->subtract('amq_latest_send', $query->expr()->literal(UserSettings::BATCH_TIME_DAILY))));
154154
} elseif ($restrictEmails === UserSettings::EMAIL_SEND_WEEKLY) {
155-
$query->where($query->expr()->eq('amq_timestamp', $query->func()->subtract('amq_latest_send', $query->expr()->literal(3600 * 24 * 7))));
155+
$query->where($query->expr()->eq('amq_timestamp', $query->func()->subtract('amq_latest_send', $query->expr()->literal(UserSettings::BATCH_TIME_WEEKLY))));
156156
} elseif ($restrictEmails === UserSettings::EMAIL_SEND_ASAP) {
157157
$query->where($query->expr()->eq('amq_timestamp', 'amq_latest_send'));
158158
}

lib/UserSettings.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,10 @@ class UserSettings {
2626
public const EMAIL_SEND_WEEKLY = 2;
2727
public const EMAIL_SEND_ASAP = 3;
2828

29+
public const BATCH_TIME_HOURLY = 3600;
30+
public const BATCH_TIME_DAILY = 3600 * 24;
31+
public const BATCH_TIME_WEEKLY = 3600 * 24 * 7;
32+
2933
/**
3034
* @param IManager $manager
3135
* @param IConfig $config
@@ -109,7 +113,7 @@ public function getAdminSetting($method, $type) {
109113
protected function getDefaultSetting($method, $type) {
110114
if ($method === 'setting') {
111115
if ($type === 'batchtime') {
112-
return 3600;
116+
return self::BATCH_TIME_HOURLY;
113117
}
114118

115119
if ($type === 'self') {

0 commit comments

Comments
 (0)