Skip to content

fix(eslint): all outstanding eslint/test issues (re:eslint9/flatconfig upgrade) #11750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ndom91 merged 18 commits into from
Sep 2, 2024
Merged

fix(eslint): all outstanding eslint/test issues (re:eslint9/flatconfig upgrade) #11750

ndom91 merged 18 commits into from
Sep 2, 2024

Conversation

@ndom91
Copy link
Member

@ndom91 ndom91 commented Sep 1, 2024

☕️ Reasoning

  • Fixed eslint setup here (This PR is required for this PR)
  • Since we haven't been using it for a while, it surfaced a bunch of legitimate issues, those are fixed here.
  • After merging that first PR (fix: eslint setup and migrate to eslint 9+flatconfig #11749) and then this one, we shuold have a working eslint setup again and no major open issues.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

@vercel
Copy link

vercel bot commented Sep 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 2, 2024 4:57pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 4:57pm
proxy ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 4:57pm

@github-actions github-actions bot added providers adapters Changes related to the core code concerning database adapters core Refers to `@auth/core` prisma @auth/prisma-adapter dynamodb @auth/dynamodb-adapter fauna @auth/fauna-adapter mikro-orm @auth/mikro-orm-adapter pouchdb @auth/pouchdb-adapter sequelize @auth/sequelize-adapter supabase @auth/supabase-adapter typeorm @auth/typeorm-adapter frameworks svelte labels Sep 1, 2024
@ndom91 ndom91 mentioned this pull request Sep 1, 2024
Merged
3 tasks
@codecov
Copy link

codecov bot commented Sep 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 55.93220% with 26 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@4b4642a). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/core/src/lib/utils/providers.ts 28.57% 5 Missing ⚠️
packages/core/src/providers/foursquare.ts 0.00% 4 Missing ⚠️
packages/core/src/providers/wechat.ts 0.00% 3 Missing ⚠️
packages/frameworks-sveltekit/src/lib/index.ts 0.00% 3 Missing ⚠️
packages/core/src/lib/actions/webauthn-options.ts 0.00% 2 Missing ⚠️
packages/next-auth/src/lib/env.ts 0.00% 2 Missing ⚠️
...es/core/src/lib/actions/callback/oauth/callback.ts 0.00% 1 Missing ⚠️
...s/core/src/lib/actions/signin/authorization-url.ts 0.00% 1 Missing ⚠️
packages/core/src/lib/utils/email.ts 0.00% 1 Missing ⚠️
packages/core/src/providers/notion.ts 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11750   +/-   ##
=======================================
  Coverage        ?   39.45%           
=======================================
  Files           ?      184           
  Lines           ?    29268           
  Branches        ?     1269           
=======================================
  Hits            ?    11549           
  Misses          ?    17719           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndom91 ndom91 changed the title feat: new flatconfig eslint.config.js fix(eslint): all outstanding eslint/test issues (re:eslint9/flatconfig upgrade) Sep 2, 2024
@ndom91 ndom91 merged commit abb4dcd into main Sep 2, 2024
@ndom91 ndom91 deleted the ndom91/eslint-fix-open-issues branch September 2, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0ubbe 0ubbe Awaiting requested review from 0ubbe

@ThangHuuVu ThangHuuVu Awaiting requested review from ThangHuuVu ThangHuuVu is a code owner

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44 balazsorban44 is a code owner

Assignees

No one assigned

Labels

adapters Changes related to the core code concerning database adapters core Refers to `@auth/core` d1 drizzle @auth/drizzle-adapter dynamodb @auth/dynamodb-adapter fauna @auth/fauna-adapter frameworks mikro-orm @auth/mikro-orm-adapter next-auth pg pouchdb @auth/pouchdb-adapter prisma @auth/prisma-adapter providers sequelize @auth/sequelize-adapter supabase @auth/supabase-adapter surrealdb svelte typeorm @auth/typeorm-adapter unstorage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ndom91