Skip to content

Conversation

@s9hn
Copy link

@s9hn s9hn commented Aug 8, 2024

πŸ“Žπ˜žπ˜°π˜³π˜¬ π˜‹π˜¦π˜΄π˜€π˜³π˜ͺ𝘱𝘡π˜ͺ𝘰𝘯

  • λ””μžμΈ μ‹œμ•ˆμ„ μ°Έκ³ ν•˜μ—¬ νšŒμ›κ°€μž… λ·°λ₯Ό κ΅¬ν˜„ν•œλ‹€.

πŸ“·π˜šπ˜€π˜³π˜¦π˜¦π˜―π˜΄π˜©π˜°π˜΅

123123.mp4

πŸ’¬π˜›π˜° π˜™π˜¦π˜·π˜ͺ𝘦𝘸𝘦𝘳𝘴

μ•ˆλ…•ν•˜μ„Έμš” 말리빈 :)
ν˜Ήμ‹œ 2단계에 UI ν…ŒμŠ€νŠΈκΉŒμ§€ ν¬ν•¨μΌκΉŒμš”? 3단계뢀터 ν…ŒμŠ€νŠΈ κ΅¬ν˜„μΈ 것 κ°™μ•„ ν˜„μž¬λŠ” 빼놓은 μƒνƒœμž…λ‹ˆλ‹€!

@s9hn s9hn changed the title Step2 πŸš€ 2단계 - νšŒμ›κ°€μž…(λ·°) Aug 8, 2024
Copy link
Member

@malibinYun malibinYun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰가 λŠ¦μ–΄μ Έμ„œ μ£„μ†‘ν•©λ‹ˆλ‹€. πŸ˜₯
2단계 λ―Έμ…˜μ˜ μ»΄ν¬λ„ŒνŠΈλ₯Ό 잘 λ‚˜λˆ„μ–΄ μ£Όμ…¨λ„€μš”!
μ½”λ©˜νŠΈ 남겨주신 것 처럼, ν…ŒμŠ€νŠΈλŠ” 3λ‹¨κ³„μ—μ„œ κ΅¬ν˜„ν•΄λ³΄μ‹œλ©΄ μ’‹κ² μ–΄μš” :)
λ‹€μŒ λ―Έμ…˜μ„ μœ„ν•΄ λ°”λ‘œ λ¨Έμ§€ν•˜κ² μŠ΅λ‹ˆλ‹€~

Comment on lines +69 to +72
val (userName, setUserName) = remember { mutableStateOf("") }
val (email, setEmail) = remember { mutableStateOf("") }
val (password, setPassword) = remember { mutableStateOf("") }
val (passwordConfirm, setPasswordConfirm) = remember { mutableStateOf("") }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

였~ MutableState의 destructureλ₯Ό ν™œμš©ν•΄μ£Όμ…¨λ„€μš”! πŸ‘

Comment on lines +131 to +132
@Composable
fun SignUpTextField(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ³΅ν†΅μœΌλ‘œ μ‚¬μš©λ  μ»΄ν¬λ„ŒνŠΈλ₯Ό 잘 λΆ„λ¦¬ν•΄μ£Όμ…¨λ„€μš”! πŸ‘

Comment on lines +111 to +113

@Composable
private fun SignUpButton() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

각 μ»΄ν¬λ„ŒνŠΈλ³„λ‘œ Previewλ₯Ό λ§Œλ“€μ–΄λ³΄λŠ” 건 μ–΄λ–¨κΉŒμš”?

Comment on lines +84 to +85
onTextChanged = { setUserName(it) },
text = userName,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ—¬κΈ°λŠ” μ•Œκ³  κ³„μ‹œκ² μ§€λ§Œ, λžŒλ‹€μ˜ 도움을 λ°›μ§€ μ•Šκ³  λ°”λ‘œ μ„ΈνŒ…ν•  μˆ˜λ„ μžˆλ‹΅λ‹ˆλ‹€!

Suggested change
onTextChanged = { setUserName(it) },
text = userName,
onTextChanged = setUserName,
text = userName,

Comment on lines +4 to +10
<!-- signup -->
<string name="signup_header_title">Welcome to Compose πŸš€</string>
<string name="signup_user_name">Username</string>
<string name="signup_email">Email</string>
<string name="signup_password">Password</string>
<string name="signup_password_confirm">Password Confirm</string>
<string name="signup_button">Sign Up</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ¬Έμžμ—΄μ„ resource νŒŒμΌμ— λΆ„λ¦¬ν•΄μ£Όμ…¨λ„€μš” πŸ‘

@malibinYun malibinYun merged commit d1a8989 into next-step:s9hn Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants