Remove runtime dependency on base64#2378
Merged
tannalynn merged 1 commit intonewrelic:devfrom Dec 22, 2023
Earlopain:base64-dep
Merged
Remove runtime dependency on base64#2378tannalynn merged 1 commit intonewrelic:devfrom Earlopain:base64-dep
tannalynn merged 1 commit intonewrelic:devfrom
Earlopain:base64-dep
Conversation
Earlopain
requested review from
fallwith,
hannahramadan,
kaylareopelle and
tannalynn
as code owners
github-actions
bot
added
the
community
The used portions of the base64 gem are just wrappers around unpack/pack
Contributor
|
Hi @Earlopain! Thanks for this PR! For anyone else who comes across this, here are some PRs from other gems using a similar approach: |
kaylareopelle
approved these changes
Dec 22, 2023
Contributor
kaylareopelle
left a comment
kaylareopelle
left a comment
There was a problem hiding this comment.
Thank you for this PR. I like this approach to handle base64 being removed from the default gems in Ruby 3.4. It's great to once again be free of dependencies! 😄
tannalynn
approved these changes
Dec 22, 2023
Contributor
Author
|
Wow, that was quick! Happy to help |
This was referenced Jan 2, 2024
Merged
This was referenced Jan 2, 2024
This was referenced Jan 15, 2024
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The used portions of the base64 gem are just wrappers around unpack/pack, dependency added in #2238 for ruby 3.3 compat.
RuboCop as an example has taken a similar approach by simply inlining this on their one callsite.
Overview
Describe the changes present in the pull request
Submitter Checklist:
Testing
The agent includes a suite of unit and functional tests which should be used to
verify your changes don't break existing functionality. These tests will run with
GitHub Actions when a pull request is made. More details on running the tests locally can be found
here for our unit tests,
and here for our functional tests.
For most contributions it is strongly recommended to add additional tests which
exercise your changes.
Reviewer Checklist