Press7 93 burst safety mode#41
Merged
arunshenoy99 merged 7 commits intorelease/v2.3.0from Jan 8, 2025
Merged
Conversation
Member
arunshenoy99
left a comment
There was a problem hiding this comment.
@AleTorrisi pointed out a few minor things. Let’s also run the lint on all the files. Everything else looks good to me, thanks 😃
arunshenoy99
reviewed
Jan 6, 2025
Member
arunshenoy99
left a comment
There was a problem hiding this comment.
Code looks good to me, @AleTorrisi. Thanks! Let’s check why the linting is failing so that we can move this to QA? It says get_option is undefined in the burst safety mode init file.
7 tasks
arunshenoy99
approved these changes
Jan 7, 2025
Member
arunshenoy99
left a comment
There was a problem hiding this comment.
Looks good to me, thanks @AleTorrisi 😄
arunshenoy99
reviewed
Jan 8, 2025
Member
arunshenoy99
left a comment
There was a problem hiding this comment.
This needs to be tested along with: bluehost/bluehost-wordpress-plugin#1499
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
At the moment, when the constant BURST_SAFETY_MODE is defined, all Newfold Labs modules stop working, thanks this code in main file inside brand plugin.
`if ( defined( 'BURST_SAFETY_MODE' ) && BURST_SAFETY_MODE ) {
}`
On admin side a static page is loaded if you try visit Bluehost Plugin dashboard.
The purpose of this branch is keep this behavior on the admin side, and force a strong cache on frontend side.
Once the module detects that BURST SAFETY MODE has been disabled, the htaccess file is restored according rules set on admin side, so cache level and Skip 404 option.
Type of Change
Production
Development
Video
REC-20241220131314.mp4
Checklist
Further comments
This branch, in order to work properly, requires a small change in the Brand plugin too, but the relative branch on that is not available at the moment.
You just need add this code at the end of the file at following path:
wp-content/plugins/bluehost-wordpress-plugin/inc/alt-experience/init.php
$bust_mode_path = dirname( __DIR__, 2 ) . '/vendor/newfold-labs/wp-module-performance/includes/BurstSafetyMode/init.php'; if ( file_exists( $bust_mode_path ) ) { require_once dirname( __DIR__, 2 ) . '/vendor/newfold-labs/wp-module-performance/includes/BurstSafetyMode/init.php'; }