Merged
Conversation
circlecube
approved these changes
Jun 3, 2025
circlecube
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The following PR will make an API call to Hiive and retrieve the URL used to render the iframe content on page load and store the full url in a cookie with of 25 minutes expiration.
This will reduce the time it takes to render the iframe, as we only need to replace the id parameter and use the ctb-id. If the urlToken fails for any reason, we will fall back to the previous method to retrieve the URL.
It will also include a listener to update the token URL when the token is refreshed and to update the cookie as well. Additionally, on each page load, the JavaScript will calculate the remaining time until the cookie expires. This way, if for some reason the customer leaves the page open without performing any actions, the cookie will still be refreshed with a new token url.
Type of Change
Production
Development
Video
Grabacion.de.pantalla.2025-05-19.a.las.16.54.57.mov
Checklist
Further comments