Conversation
This standardizes the Node.js setup by: - Introducing an `.nvmrc` file specifying the version of Node.js to use when working with the repository. - Added `engines` to the `package.json` file.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes the Node.js setup across the repository by establishing Node.js 22.11.0 as the minimum required version, aligning with the current LTS release. The changes ensure consistent Node.js environments for development and CI/CD workflows.
- Adds Node.js version constraints to package.json and .nvmrc for development environment consistency
- Updates GitHub Actions workflows to use Node.js 22 for testing and releases
- Standardizes Node.js version specification across different brand plugin test workflows
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Adds engines field specifying Node.js >=22.11.0 and npm >=10.9.0 requirements |
| .nvmrc | Creates Node Version Manager config file specifying Node.js version 22 |
| .github/workflows/newfold-prep-release.yml | Adds node-version parameter set to '22' for release workflow |
| .github/workflows/brand-plugin-test.yml | Updates node-version from 20 to '22' across multiple brand workflows |
newfold-labs/workflows#84 will change the default value to `22`. Once all modules have an `.nvmrc` file, that will be used instead.
girish-lokapure
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This standardizes the Node.js setup by:
.nvmrcfile specifying the version of Node.js to use when working with the repository.enginesto thepackage.jsonfile.Since 22.x is the current LTS version of Node.js,
22.11.0is used as the minimum required version since it represents the release that transitioned the version from current to LTS status. The version ofnpmused (10.9.0) is the version bundled with22.11.0This also includes updates to the
package-lock.jsonfile that were missed previously. These changes are a result of runningnpm installbefore making any other changes in this pull request, but should still be examined and tested carefully.The GitHub Action workflows have been updated to ensure the desired version is used for testing and releasing, however the release workflow requires newfold-labs/workflows#77 to be merged first.
This addresses PRESS0-2909 and PRESS0-2910.
Type of Change
Production
Development
Visual
Checklist
Further comments