Use untrailingslashit() on server_path#170
Merged
BrianHenryIE merged 2 commits intomainfrom May 23, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that the server_path value returned by get_core_data() has no trailing slash by applying untrailingslashit(), and updates the corresponding test to expect the stripped value.
- Wrap
server_pathinuntrailingslashit()in the production code - Add a mock for
untrailingslashit()and update the expected value in the PHPUnit test
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| includes/HiiveConnection.php | Apply untrailingslashit() to the server_path entry |
| tests/phpunit/includes/HiiveConnectionTest.php | Mock untrailingslashit() and update the expected server_path |
Comments suppressed due to low confidence (1)
tests/phpunit/includes/HiiveConnectionTest.php:122
- Add a test case where
ABSPATHis undefined or empty to verify thatserver_pathfalls back to an empty string without errors.
self::assertEquals( '/path/on/server', $result['server_path'] );
Contributor
Co-authored-by: Copilot <[email protected]>
fralicandro
approved these changes
May 23, 2025
BrianHenryIE
deleted the
PRESS0-2763/remove-trailing-slash-from-server-path
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Type of Change
Production
Development
Video
Checklist
Further comments