Use expected object name for localized script#164
Merged
circlecube merged 1 commit intomainfrom May 12, 2025
Merged
Conversation
Contributor
wpscholar
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The
nfd-hiive-eventsobject isn't a valid name:wp-module-data/includes/Data.php
Line 122 in 7ec3d5d
Furthermore, it isn't used by the click events script (see: https://github.com/newfold-labs/wp-module-data/blob/main/assets/click-events.js#L44).
This updates it to the expected
nfdHiiveEventsname, which is a valid name.Type of Change
Production
Development
Video
Checklist
Further comments