Skip to content

Event Creation Date#137

Merged
arunshenoy99 merged 73 commits intoFIX/PRESS7-375-fix-retry-logicfrom
enhance/event-creation-date
May 2, 2025
Merged

Event Creation Date#137
arunshenoy99 merged 73 commits intoFIX/PRESS7-375-fix-retry-logicfrom
enhance/event-creation-date

Conversation

@AleTorrisi
Copy link
Copy Markdown
Contributor

Proposed changes

This pull request modifies the database entry logic so that the actual creation date of the event ($event->created_at) is used instead of the current time ($time), when available.

Previous Behaviour

Currently, the "created_at" field is always populated with the current value of $time, regardless of the actual date of the event.

New Behaviour

With this change, if the $event object contains a created_at property, this is used to populate the created_at field in the database. Only in the absence of this property is the current value ($time) used as fallback.

Reason
This change is necessary to ensure that the recorded date correctly reflects the time when the event was actually generated, improving the accuracy and traceability of the data.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

BrianHenryIE and others added 30 commits September 13, 2024 13:01
Prevent fatal error if WC()->cart is null or not an instance of WC_Cart
…tributes

* main: (113 commits)
  Prevent fatal error if WC()->cart is null or not an instance of WC_Cart
  Pin full length commit SHA for 3rd party actions.
  version bump to 2.6.11
  Register hooks of Commerce Listener only when WooCommerce is enabled
  Update static site-classification-data-to-0.0.6
  Add checks for Commerce Listeners hooks that requires WooCommerce
  update plugin paths in test files
  swap bluehost repo path with new one
  Version updated 2.6.9 => 2.6.10
  Remove mock for `get_current_user_id()`
  Mock get_current_user_id() and expect status to equal connected
  Set REMOTE_ADDR
  Ensure we properly handle status changes
  Exclude phpunit cache
  Return value and add return type
  Use pre_update_option hook
  update test workflow bluehost plugin path
  bump version to 2.6.9
  add version bump script and command
  ensure capabilities is_array
  ...
@github-actions
Copy link
Copy Markdown
Contributor

@arunshenoy99 arunshenoy99 changed the base branch from main to FIX/PRESS7-375-fix-retry-logic May 2, 2025 07:17
@arunshenoy99
Copy link
Copy Markdown
Member

@AleTorrisi, let’s merge this into FIX/PRESS7-375-fix-retry-logic so we have everything in a single place and we can address any conflicts earlier. I see one conflict, can we resolve that? Thanks!

@arunshenoy99 arunshenoy99 merged commit 9dececa into FIX/PRESS7-375-fix-retry-logic May 2, 2025
1 check passed
@arunshenoy99 arunshenoy99 deleted the enhance/event-creation-date branch May 2, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants