PRESS0-1996: Add Hiive events via HTML attributes#101
Merged
BrianHenryIE merged 6 commits intomainfrom Apr 17, 2025
Merged
Conversation
9 tasks
Member
|
@wpscholar and @bradp - where are we with this? Does it still need work or just approval/testing? I see it is related to a marketplace PR too, anything I can do to help wrap them up? Is there an associated jira ticket for any more context? |
Member
|
@circlecube Yes, I was just looking at this today. There are some JIRA tickets on my plate to follow up on this. |
circlecube
previously approved these changes
Apr 14, 2025
…tributes * main: (113 commits) Prevent fatal error if WC()->cart is null or not an instance of WC_Cart Pin full length commit SHA for 3rd party actions. version bump to 2.6.11 Register hooks of Commerce Listener only when WooCommerce is enabled Update static site-classification-data-to-0.0.6 Add checks for Commerce Listeners hooks that requires WooCommerce update plugin paths in test files swap bluehost repo path with new one Version updated 2.6.9 => 2.6.10 Remove mock for `get_current_user_id()` Mock get_current_user_id() and expect status to equal connected Set REMOTE_ADDR Ensure we properly handle status changes Exclude phpunit cache Return value and add return type Use pre_update_option hook update test workflow bluehost plugin path bump version to 2.6.9 add version bump script and command ensure capabilities is_array ...
Member
|
I got this updated from main and fixed a fatal error where the container wasn't being passed to the constructor. Seeing some failing Unit tests on it though, @wpscholar can you take a look when you get a chance? |
Contributor
wpscholar
approved these changes
Apr 17, 2025
BrianHenryIE
deleted the
feature/PRESS0-1996-hiive-events-via-html-attributes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change allows for adding HTML attributes to an element and will send an event to Hiive when the element is clicked.
The attributes you can add are:
data-nfd-clickRequired. Will be used as the key if no other attributes are used.data-nfd-event-keyOptional. Used as key if present.data-nfd-event-categoryOptional. Used as category if present.data-nfd-brandOptional. Used to override brand if present.data-nfd-queueOptional. Will set the event to be queued.data-nfd-product-idOptional. Used for marketplace items.Type of Change
Checklist