Lists.transform is lazy therefore retrying will always occur regardless if insertIds are set

neuromantik33 · neuromantik33 · commit 984b5bb41cfb · 2018-05-30T00:08:46.000+02:00
diff --git a/google-cloud-clients/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryImpl.java b/google-cloud-clients/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryImpl.java
@@ -40,9 +40,9 @@
 import com.google.common.annotations.VisibleForTesting;
 import com.google.common.base.Function;
 import com.google.common.base.Supplier;
+import com.google.common.collect.FluentIterable;
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.Iterables;
-import com.google.common.collect.Lists;
 import com.google.common.collect.Maps;
 import java.util.List;
 import java.util.Map;
@@ -468,13 +468,15 @@ public InsertAllResponse insertAll(InsertAllRequest request) {
     // Using an array of size 1 here to have a mutable boolean variable, which can be modified in
     // an anonymous inner class.
     final boolean[] allInsertIdsSet = {true};
-    List<Rows> rowsPb = Lists.transform(request.getRows(), new Function<RowToInsert, Rows>() {
-      @Override
-      public Rows apply(RowToInsert rowToInsert) {
-        allInsertIdsSet[0] &= rowToInsert.getId() != null;
-        return new Rows().setInsertId(rowToInsert.getId()).setJson(rowToInsert.getContent());
-      }
-    });
+    List<Rows> rowsPb = FluentIterable.from(request.getRows())
+        .transform(new Function<RowToInsert, Rows>() {
+          @Override
+          public Rows apply(RowToInsert rowToInsert) {
+            allInsertIdsSet[0] &= rowToInsert.getId() != null;
+            return new Rows().setInsertId(rowToInsert.getId()).setJson(rowToInsert.getContent());
+          }
+        })
+        .toList();
     requestPb.setRows(rowsPb);
 
     TableDataInsertAllResponse responsePb;
