set cluster name from user after authorization#715
Merged
zubenkoivan merged 3 commits intomasterfrom May 22, 2019
Merged
Conversation
atemate
reviewed
May 21, 2019
tests/unit/test_job_service.py
Outdated
| await jobs_service.create_job(mock_job_request, user) | ||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_create_job_with_non_default_user_cluster_name( |
There was a problem hiding this comment.
Please note that this test does not touch changes in authorized_user(): to test them, we need to add an integration test on api level
zubenkoivan
force-pushed
the
set_cluster_name_from_user
branch
from
830bc53 to
a5439d4
Compare
Codecov Report
@@ Coverage Diff @@
## master #715 +/- ##
=========================================
+ Coverage 93.92% 94.12% +0.2%
=========================================
Files 32 32
Lines 3948 3948
Branches 422 422
=========================================
+ Hits 3708 3716 +8
+ Misses 179 172 -7
+ Partials 61 60 -1
|
Contributor
|
I think that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #712