Skip to content

Remove deprecated SSH-related commands from the client#700

Merged
asvetlov merged 8 commits intomasterfrom
an/remove-legacy-ssh
Apr 11, 2019
Merged

Remove deprecated SSH-related commands from the client#700
asvetlov merged 8 commits intomasterfrom
an/remove-legacy-ssh

Conversation

@anayden
Copy link
Copy Markdown
Contributor

@anayden anayden commented Apr 9, 2019

This PR addresses client-side component of neuro-inc/platform-api#515

Removing the neuro model command, the neuro config id_rsa subcommand and the neuro job submit --ssh option.

  • The whole neuro model command has been deprecated for a few months.
  • neuro job submit --ssh has been deprecated for a few months as well.
  • neuro config id_rsa has been hidden for quite a while and has no use cases without the commands above.

@anayden anayden requested review from asvetlov and atemate April 9, 2019 15:52
@astaff astaff added the platform label Apr 9, 2019
@dalazx
Copy link
Copy Markdown
Contributor

dalazx commented Apr 9, 2019

@truskovskiyk fyi

@dalazx
Copy link
Copy Markdown
Contributor

dalazx commented Apr 9, 2019

@anayden awesome!

should we update the changelog?
cc @asvetlov

@asvetlov
Copy link
Copy Markdown
Contributor

Yes, sure.
The change worth CHANGELOG record

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2019

Codecov Report

Merging #700 into master will increase coverage by 1.75%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #700      +/-   ##
==========================================
+ Coverage   90.43%   92.19%   +1.75%     
==========================================
  Files          40       39       -1     
  Lines        3230     3112     -118     
  Branches      445      437       -8     
==========================================
- Hits         2921     2869      -52     
+ Misses        237      179      -58     
+ Partials       72       64       -8
Impacted Files Coverage Δ
neuromation/cli/ssh_utils.py 0% <ø> (-19.15%) ⬇️
neuromation/cli/config.py 87.5% <ø> (+0.48%) ⬆️
neuromation/cli/formatters/config.py 100% <ø> (ø) ⬆️
neuromation/api/models.py 96.29% <100%> (-3.71%) ⬇️
neuromation/cli/job.py 92.22% <100%> (+1.54%) ⬆️
neuromation/cli/rc.py 93.4% <100%> (+0.86%) ⬆️
neuromation/api/jobs.py 93.42% <100%> (+0.22%) ⬆️
neuromation/cli/main.py 60.71% <100%> (+0.3%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5e2deb...46dc100. Read the comment docs.

@asvetlov asvetlov merged commit 49e2462 into master Apr 11, 2019
@asvetlov asvetlov deleted the an/remove-legacy-ssh branch April 11, 2019 07:34
neu-ro-github-bot bot pushed a commit that referenced this pull request Sep 3, 2025
Bumps [towncrier](https://github.com/twisted/towncrier) from 24.8.0 to
25.8.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/twisted/towncrier/releases">towncrier's
releases</a>.</em></p>
<blockquote>
<h2>Towncrier 25.8.0</h2>
<h1>towncrier 25.8.0 (2025-08-30)</h1>
<h2>Features</h2>
<ul>
<li>Support was added for Mercurial SCM.
(<code>[#394](twisted/towncrier#394)
&lt;https://github.com/twisted/towncrier/issues/394&gt;</code>_)</li>
<li>The <code>towncrier check</code> command now has a
<code>--staged</code> flag to inspect the files staged for commit when
checking for a news fragment: useful in a pre-commit hook
(<code>[#676](twisted/towncrier#676)
&lt;https://github.com/twisted/towncrier/issues/676&gt;</code>_)</li>
<li>When used with an <code>pyproject.toml</code> file, when no explicit
values are
defined for [tool.towncrier.name|package] they will now fallback to
the value of [project.name].
(<code>[#687](twisted/towncrier#687)
&lt;https://github.com/twisted/towncrier/issues/687&gt;</code>_)</li>
<li>More simple configuration for Keep a Changelog style changelogs
(<code>[#691](twisted/towncrier#691)
&lt;https://github.com/twisted/towncrier/issues/691&gt;</code>_)</li>
<li>Added support for Python 3.13 and removed support for Python 3.8.
(<code>[#700](twisted/towncrier#700)
&lt;https://github.com/twisted/towncrier/issues/700&gt;</code>_)</li>
</ul>
<h2>Bugfixes</h2>
<ul>
<li>Multi-line newsfragments that ends with a code block will now have a
newline inserted before appending the link to the issue, to avoid
breaking formatting.
(<code>[#614](twisted/towncrier#614)
&lt;https://github.com/twisted/towncrier/issues/614&gt;</code>_)</li>
<li>Markdown header level is correctly inferred from
<code>title_format</code>.
(<code>[#695](twisted/towncrier#695)
&lt;https://github.com/twisted/towncrier/issues/695&gt;</code>_)</li>
</ul>
<h2>Improved Documentation</h2>
<ul>
<li>The documentation RST source files are now included in the sdist
package. (<code>[#672](twisted/towncrier#672)
&lt;https://github.com/twisted/towncrier/issues/672&gt;</code>_)</li>
<li>Refactor the default markdown template to make it easier to
understand, extend, and customize.
(<code>[#706](twisted/towncrier#706)
&lt;https://github.com/twisted/towncrier/issues/706&gt;</code>_)</li>
</ul>
<h2>Deprecations and Removals</h2>
<ul>
<li>When no sections are present,
the default Markdown template now renders the category headers as H2.
In previous versions it was rendered as H3.
(<code>[#663](twisted/towncrier#663)
&lt;https://github.com/twisted/towncrier/issues/663&gt;</code>_)</li>
</ul>
<h2>Misc</h2>
<ul>
<li><code>[#667](twisted/towncrier#667)
&lt;https://github.com/twisted/towncrier/issues/667&gt;</code><em>,
<code>[#669](twisted/towncrier#669)
&lt;https://github.com/twisted/towncrier/issues/669&gt;</code></em>,
<code>[#679](twisted/towncrier#679)
&lt;https://github.com/twisted/towncrier/issues/679&gt;</code><em>,
<code>[#680](twisted/towncrier#680)
&lt;https://github.com/twisted/towncrier/issues/680&gt;</code></em>,
<code>[#682](twisted/towncrier#682)
&lt;https://github.com/twisted/towncrier/issues/682&gt;</code><em>,
<code>[#701](twisted/towncrier#701)
&lt;https://github.com/twisted/towncrier/issues/701&gt;</code></em>,
<code>[#702](twisted/towncrier#702)
&lt;https://github.com/twisted/towncrier/issues/702&gt;</code><em>,
<code>[#713](twisted/towncrier#713)
&lt;https://github.com/twisted/towncrier/issues/713&gt;</code></em></li>
</ul>
<h2>Towncrier 25.8.0rc2</h2>
<h1>towncrier 25.8.0rc2 (2025-08-15)</h1>
<h2>Features</h2>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/twisted/towncrier/blob/trunk/NEWS.rst">towncrier's
changelog</a>.</em></p>
<blockquote>
<h1>towncrier 25.8.0 (2025-08-30)</h1>
<p>No significant changes since the previous release candidate.</p>
<h2>Features</h2>
<ul>
<li>Support was added for Mercurial SCM.
(<code>[#394](twisted/towncrier#394)
&lt;https://github.com/twisted/towncrier/issues/394&gt;</code>_)</li>
<li>The :command:<code>towncrier check</code> command now has a
<code>--staged</code> flag to inspect the files staged for commit when
checking for a news fragment: useful in a pre-commit hook
(<code>[#676](twisted/towncrier#676)
&lt;https://github.com/twisted/towncrier/issues/676&gt;</code>_)</li>
<li>When used with an :file:<code>pyproject.toml</code> file, when no
explicit values are
defined for <code>[tool.towncrier.name|package]</code> they will now
fallback to
the value of <code>[project.name]</code>.
(<code>[#687](twisted/towncrier#687)
&lt;https://github.com/twisted/towncrier/issues/687&gt;</code>_)</li>
<li>The <code>directory</code> configuration option is no longer
required.
It can now be generated based on value from the <code>name</code>
configuration.
(<code>[#691](twisted/towncrier#691)
&lt;https://github.com/twisted/towncrier/issues/691&gt;</code>_)</li>
<li>Added support for Python 3.13 and removed support for Python 3.8.
(<code>[#700](twisted/towncrier#700)
&lt;https://github.com/twisted/towncrier/issues/700&gt;</code>_)</li>
</ul>
<h2>Bugfixes</h2>
<ul>
<li>Multi-line news fragments that end with a code block will now have a
newline inserted before appending the link to the issue, to avoid
breaking formatting.
(<code>[#614](twisted/towncrier#614)
&lt;https://github.com/twisted/towncrier/issues/614&gt;</code>_)</li>
<li>Markdown header level is correctly inferred from
<code>title_format</code>.
(<code>[#695](twisted/towncrier#695)
&lt;https://github.com/twisted/towncrier/issues/695&gt;</code>_)</li>
</ul>
<h2>Improved Documentation</h2>
<ul>
<li>The documentation RST source files are now included in the sdist
package. (<code>[#672](twisted/towncrier#672)
&lt;https://github.com/twisted/towncrier/issues/672&gt;</code>_)</li>
<li>Refactor the default markdown template to make it easier to
understand, extend, and customize.
(<code>[#706](twisted/towncrier#706)
&lt;https://github.com/twisted/towncrier/issues/706&gt;</code>_)</li>
</ul>
<h2>Deprecations and Removals</h2>
<ul>
<li>Support for Python 3.8 was removed.
(<code>[#700](twisted/towncrier#700)
&lt;https://github.com/twisted/towncrier/issues/700&gt;</code>_)</li>
<li>When no sections are present,
the default Markdown template now renders the category headers as H2.
In previous versions it was rendered as H3.
(<code>[#663](twisted/towncrier#663)
&lt;https://github.com/twisted/towncrier/issues/663&gt;</code>_)</li>
</ul>
<h2>Misc</h2>
<ul>
<li><code>[#667](twisted/towncrier#667)
&lt;https://github.com/twisted/towncrier/issues/667&gt;</code><em>,
<code>[#669](twisted/towncrier#669)
&lt;https://github.com/twisted/towncrier/issues/669&gt;</code></em>,
<code>[#679](twisted/towncrier#679)
&lt;https://github.com/twisted/towncrier/issues/679&gt;</code><em>,
<code>[#680](twisted/towncrier#680)
&lt;https://github.com/twisted/towncrier/issues/680&gt;</code></em>,
<code>[#682](twisted/towncrier#682)
&lt;https://github.com/twisted/towncrier/issues/682&gt;</code><em>,
<code>[#701](twisted/towncrier#701)
&lt;https://github.com/twisted/towncrier/issues/701&gt;</code></em>,
<code>[#702](twisted/towncrier#702)
&lt;https://github.com/twisted/towncrier/issues/702&gt;</code><em>,
<code>[#713](twisted/towncrier#713)
&lt;https://github.com/twisted/towncrier/issues/713&gt;</code></em></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/twisted/towncrier/commit/762c8f28d625979812db33b9446c24bee701ba0b"><code>762c8f2</code></a>
Prepare final version.</li>
<li><a
href="https://github.com/twisted/towncrier/commit/fb2c84213a578aaefc52f02d318b93a3679254bc"><code>fb2c842</code></a>
Update NEWS.rst</li>
<li><a
href="https://github.com/twisted/towncrier/commit/aae1d3307bda638ced5dc9da2a0ef09d02962902"><code>aae1d33</code></a>
Apply suggestions from code review</li>
<li><a
href="https://github.com/twisted/towncrier/commit/cb696b2237e0840b171eb872ce7f5608295f9b80"><code>cb696b2</code></a>
[pre-commit.ci] auto fixes from pre-commit.com hooks</li>
<li><a
href="https://github.com/twisted/towncrier/commit/10bbd8e5e8443bf1f0abe20fe07839302cef747f"><code>10bbd8e</code></a>
Fix version string.</li>
<li><a
href="https://github.com/twisted/towncrier/commit/5f4639a55ba0a68da0146b000e0772bb9947a2cf"><code>5f4639a</code></a>
Merge origin.</li>
<li><a
href="https://github.com/twisted/towncrier/commit/234ebc5dbc43f7f8539c053135cec6a5773449f3"><code>234ebc5</code></a>
Fix version.</li>
<li><a
href="https://github.com/twisted/towncrier/commit/8547ca9a201be62f64c577d032b18aca6409e6b6"><code>8547ca9</code></a>
Update releae candidate.</li>
<li><a
href="https://github.com/twisted/towncrier/commit/5347588877a5447d0ef01dd2093e445d74e8a583"><code>5347588</code></a>
[pre-commit.ci] auto fixes from pre-commit.com hooks</li>
<li><a
href="https://github.com/twisted/towncrier/commit/e5853c5dd1ef69c05a66e9ac5f36f364725b458d"><code>e5853c5</code></a>
Update releae candidate.</li>
<li>Additional commits viewable in <a
href="https://github.com/twisted/towncrier/compare/24.8.0...25.8.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=towncrier&package-manager=pip&previous-version=24.8.0&new-version=25.8.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants