This repository was archived by the owner on Jun 3, 2025. It is now read-only.
Transformers refactor #861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natuan
requested review from
KSGulin,
anmarques,
bfineran,
dbogunowicz,
markurtz,
mgoin,
rahul-tuli and
spacemanidol
Member
|
Could we update the description with the code for loading best model for QA before landing? |
rahul-tuli
previously approved these changes
Aug 3, 2022
natuan
force-pushed
the
transformers_refactor
branch
from
5d417e1 to
f193ccc
Compare
natuan
force-pushed
the
transformers_refactor
branch
from
f193ccc to
15e8b3b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's not possible for the two trainers in sparseml transformers both extending a functionality from the upstream HuggingFace Trainer and sharing common code. This PR is to fix that, for now enabling them share saving best model after a specified epoch and removing unused column.
Additionally, create common training args for different training flows, and let them share distill teacher and recipe args. The same could be done when needed for data and model args.
Qualification: tested with load best model after epoch for QA flow.