Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

Conversation

@KSGulin
Copy link
Contributor

@KSGulin KSGulin commented Oct 14, 2022

Updates to support the Neural Magic integration fork upgrade to v4.23. Refer to neuralmagic/transformers#62 for details and testing

@github-actions
Copy link

@bfineran assigned for review

@KSGulin KSGulin requested review from a team, anmarques and natuan and removed request for a team October 14, 2022 10:42
@KSGulin KSGulin changed the title Updates needed to support transformers v4.23 Updates needed to support transformers v4.23.1 Oct 14, 2022
corey-nm
corey-nm previously approved these changes Oct 14, 2022
bfineran
bfineran previously approved these changes Oct 14, 2022
@bfineran
Copy link
Contributor

Ready to land pending build of transformers fork from neuralmagic/transformers#62

rahul-tuli
rahul-tuli previously approved these changes Oct 19, 2022
Copy link
Member

@rahul-tuli rahul-tuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting the blocking diff has landed. Another check mark! Merge away

@KSGulin KSGulin dismissed stale reviews from rahul-tuli, bfineran, and corey-nm via 1a0ca0b October 28, 2022 18:37
rahul-tuli
rahul-tuli previously approved these changes Oct 28, 2022
bfineran
bfineran previously approved these changes Oct 28, 2022
@KSGulin KSGulin dismissed stale reviews from bfineran and rahul-tuli via 09d44e7 October 28, 2022 19:13
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for getting on this!

@mgoin mgoin merged commit c89be50 into main Oct 28, 2022
@mgoin mgoin deleted the support_transformers_v4.23 branch October 28, 2022 19:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants