This repository was archived by the owner on Jun 3, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 157
Updates needed to support transformers v4.23.1 #1081
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bfineran assigned for review |
corey-nm
previously approved these changes
Oct 14, 2022
bfineran
previously approved these changes
Oct 14, 2022
Contributor
|
Ready to land pending build of transformers fork from neuralmagic/transformers#62 |
rahul-tuli
previously approved these changes
Oct 19, 2022
Member
rahul-tuli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting the blocking diff has landed. Another check mark! Merge away
1a0ca0b
rahul-tuli
previously approved these changes
Oct 28, 2022
bfineran
previously approved these changes
Oct 28, 2022
rahul-tuli
approved these changes
Oct 28, 2022
mgoin
approved these changes
Oct 28, 2022
Member
mgoin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for getting on this!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to support the Neural Magic integration fork upgrade to v4.23. Refer to neuralmagic/transformers#62 for details and testing