Repository navigation
Keep 0 and False in concat merge outputs - #1323
Merged
davidmezzetti merged 1 commit intoOct 4, 2026
Merged
Conversation
Member
|
LGTM - Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / why
Task.concatmerged multi-action outputs with a truthiness filter (if y), so a0,0.0orFalseresult was dropped from the merged string instead of being written into it:A quantity of 0 is real data. Only
Noneand""contribute nothing but a separator, so the guard now skips exactly those - the same rule the tabular pipeline already applies inTabular.concat(column is not None and column != "", covered bytestFalsyValues).Closes #1322
Checks
test/python/testworkflow.pyon Python 3.11, base893d042:testMergeWorkflowFalsyValuesfails on base withAssertionError: Lists differ: ['Widget', '5. Gadget'] != ['0. Widget', '5. Gadget']and passes with this changetestMergeWorkflow,testMergeUnbalancedWorkflowandtestIteratorActions(which loops overhstack/vstack/concat/None)6 failed, 35 passedwith this change vs6 failed, 34 passedon a base checkout of the same environment - the 6 failures are the identical set of pre-existing local gaps (optionalpipeline/workflowextras not installed, image model), none is an assertion in the merge pathblack --checkclean,pylint10.00/10 with the repo.pylintrcnp.stackrows give scalars, andnp.float64(0.0) != ""returnsnp.bool_without warnings under-W error::DeprecationWarning, so array merges keep working (['0.0. 1.0', '5.0. 6.0'])Note
AI-assisted: this change was drafted and verified locally with an AI coding assistant (reproduction, RED/GREEN runs and lint above).