Rm deprecated np.row_stack in favor of vstack. #7390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschult
approved these changes
Apr 4, 2024
Member
dschult
left a comment
dschult
left a comment
There was a problem hiding this comment.
Nice!!
Thanks for this update -- and for the news about matplotlib and green checks!
cvanelteren
pushed a commit
to cvanelteren/networkx
that referenced
this pull request
Apr 22, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling a new deprecation from the NumPy 2.1 nightlies.
On an unrelated note, matplotlib has released v3.8.4 with support for numpy 2.0. This release (along with the latest mpl 3.9.0dev nightly wheel) fixes the test failures that had been cropping up in
test_pylabwith numpy 2.0. In other words, NX is now green across the board with numpy 2.0, scipy 1.13, and matplotlib 3.8.4!