drivers/nutdrv_qx_gtec.c: multiple status letters can be reported at once#2834
Merged
jimklimov merged 2 commits intonetworkupstools:masterfrom Mar 11, 2025
Merged
drivers/nutdrv_qx_gtec.c: multiple status letters can be reported at once#2834jimklimov merged 2 commits intonetworkupstools:masterfrom
jimklimov merged 2 commits intonetworkupstools:masterfrom
Conversation
…once Signed-off-by: Lukáš Turek <[email protected]>
jimklimov
added
enhancement
USB
Qx protocol driver
Member
|
Thanks, seems good as far as code change goes. I'll trust you on the subject matter :) |
…v_qx [networkupstools#2818, networkupstools#2834] Signed-off-by: Jim Klimov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few small fixes of the GTEC driver: only letters for online/offline/bypass status are mutually exclusive, other states like low battery can be reported in addition to them. Also add alarm when battery is disconnected and set replace battery status when battery test had failed.
Follow-up to: #2818