upsmon: introduce OBLBDURATION config toggle#2406
Merged
jimklimov merged 1 commit intonetworkupstools:masterfrom Apr 17, 2024
Merged
upsmon: introduce OBLBDURATION config toggle#2406jimklimov merged 1 commit intonetworkupstools:masterfrom
OBLBDURATION config toggle#2406jimklimov merged 1 commit intonetworkupstools:masterfrom
Conversation
jimklimov
added
enhancement
need testing
…upstools#321] Signed-off-by: Jim Klimov <[email protected]>
jimklimov
added
the
ready / code review
Contributor
|
Hello Jim, thanks for your effort, I've tested all scenarios (OBLBDURATION -1, OBLBDURATION 0, OBLBDURATION 30, OBLBDURATION not set) and can confirm everything is working as it should. Code-review looking good and reasonable too, the increased polling frequency and countdown-style warning messages are an informative and useful touch. Rysz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Largely follows in the footsteps of #2104 which introduced the
OFFDURATIONtoggle.This PR adds an
OBLBDURATIONtoggle to delay issuing FSD (primary) or commencing a shutdown afterHOSTSYNC(secondary without a seen FSD alert), for users that deem this desirable (some use-cases suggested in issue #321 discussion - primarily to survive short hiccups that happen at the wrong moment) at their discretion and risk of an ungraceful shutdown.Closes: #321
CC @desertwitch @dark-penguin @clepple @aquette
Testing in practice would be as welcome as code review :)