nut-scanner: report same USB matching values as seeked by libusb{0,1}.c#1795
Merged
jimklimov merged 3 commits intonetworkupstools:masterfrom Jan 11, 2023
Merged
nut-scanner: report same USB matching values as seeked by libusb{0,1}.c#1795jimklimov merged 3 commits intonetworkupstools:masterfrom
jimklimov merged 3 commits intonetworkupstools:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1790
Currently nut-scanner did not report a
devicevalue (should mean physical port number on a hub, where supported and not much guaranteed), so systems connected to two UPSes from same vendor could not discern between them (especially if handled by same USB bus, and lacking a serial number).Many USB drivers use the common routine (more after #1763 was merged) which checks for
device = NNNif provided.For that matter, the common matcher also reports (and considers internally) the "bcdDevice" (version) although does not match it from user-provided configuration. FWIW this change prints that value out, commented.
Example output after the change:
which matches
lsusbreport: