m4/nut_check_libusb.m4: when on Windows, prefer libusb-0.1 [#1507]#1629
Merged
jimklimov merged 3 commits intonetworkupstools:Windows-v2.8.0-1from Aug 30, 2022
Merged
Conversation
|
❌ Build nut 2.8.0.31-Windows-v2.8.0-1 failed (commit ee8a244ca7 by @jimklimov) |
Member
Author
|
Regarding AppVeyor fail: Huh, this relies on #1628 to be there, for MSYS2 builds. Will retry after merging that one. |
configure.ac, drivers/libusb0.c: fix detection of strlwr() and fallback strcasestr() implem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not really sure if this would help (checking) but the Windows branch was originally developed before libusb-1.0 effort started, so tweaks to code applied to what is now
libusb0.cshould be more successful.In limited dev-testing so far, builds with plain libusb-1.0 and with it wrapped as libusb-0.1-compat (mis-)behave in a similar manner, claiming I/O errors with interrupt processing mode, and nearly no data collected with polling mode. Maybe snatching the device from "kernel" should be done differently (Windows does represent the "USB HID Battery" and probably holds the critical resources).
Have yet to try with original libusb-win32 project the branch was built against.