Repository navigation
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #931 +/- ##
============================================
+ Coverage 78.66% 79.04% +0.37%
- Complexity 1432 1504 +72
============================================
Files 136 143 +7
Lines 4692 4915 +223
Branches 896 932 +36
============================================
+ Hits 3691 3885 +194
- Misses 644 670 +26
- Partials 357 360 +3 ☔ View full report in Codecov by Sentry. |
stevehu
pushed a commit
that referenced
this pull request
Jul 7, 2026
In OSGi runtimes the thread context class loader cannot see this library's bundled meta-schemas, so resolution fails with FileNotFoundException: classpath:draft/2020-12/schema. The 1.x ClasspathURLStreamHandler chained class loaders; the chain was not carried over in the schema retrieval refactor (#931). The fallback runs only after the TCCL misses, so flat classpath behavior is unchanged, and it is skipped when a custom class loader source is supplied.
stevehu
pushed a commit
that referenced
this pull request
Jul 7, 2026
In OSGi runtimes the thread context class loader cannot see this library's bundled meta-schemas, so resolution fails with FileNotFoundException: classpath:draft/2020-12/schema. The 1.x ClasspathURLStreamHandler chained class loaders; the chain was not carried over in the schema retrieval refactor (#931). The fallback runs only after the TCCL misses, so flat classpath behavior is unchanged, and it is skipped when a custom class loader source is supplied.
4 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #920, closes #884, closes #877, closes #855, closes #854, closes #840, closes #742
This PR includes breaking changes.
This adds support for the following required for Draft 2020-12 support
$dynamicRef$dynamicAnchor$vocabularyThis refactors the schema retrieval codes as the ID is based on IRI and not URI.
Note that Java does not support IRIs. See https://cr.openjdk.org/%7Edfuchs/writeups/updating-uri/ for details.
The following are removed and replaced by
SchemaLoaderandSchemaMapper.URIFactory- No replacement. The resolve logic is inAbsoluteIRI.URISchemeFactory- No replacement asURIFactoryisn't required anymore.URISchemeFetcher- No replacement. TheSchemaLoadersare iterated and called.URITranslator- Replaced bySchemaMapper.URLFactory- No replacement asURIFactoryisn't required anymore.URLFetcher- Replaced byUriSchemaLoader.URNURIFactory- No replacement asURIFactoryisn't required anymore.The
SchemaLoaderandSchemaMapperare configured in theJsonSchemaFactory.Builder.As per the specification. The
formatkeyword since Draft 2019-09 no longer generates assertions by default.This can be changed by using a custom meta schema with the relevant
$vocabularyor by setting the execution configuration to enable format assertions.This PR also updates the documentation and includes a section on migrating to newer versions. This also includes miscellaneous fixes.
Functional Comparison
With Changes
fail: r:9 (0.2%) o:1 (0.0%)
fail: r:0 (0.0%) o:0 (0.0%)
fail: r:0 (0.0%) o:0 (0.0%)
fail: r:0 (0.0%) o:0 (0.0%)
fail: r:3 (0.2%) o:0 (0.0%)
fail: r:6 (0.5%) o:1 (0.2%)
Performance Comparison
With Changes