Skip to content

CI: fix Windows build and update CI + build settings#1199

Merged
fabratu merged 4 commits intonetworkit:masterfrom
fabratu:20240311_ci_update
Mar 27, 2024
Merged

CI: fix Windows build and update CI + build settings#1199
fabratu merged 4 commits intonetworkit:masterfrom
fabratu:20240311_ci_update

Conversation

@fabratu
Copy link
Copy Markdown
Member

@fabratu fabratu commented Mar 26, 2024 •
edited
Loading

Notes:

  • GCC is not updated to 13.X for macOS, since the compiler is currently broken when working with libomp on CI (not reproducible locally).
  • clang-tidy is not updated to 18.X. This is out of scope for this PR, due to non-minor refactoring.
  • The -permissive flag is added for MSVC builds, since when building with Visual Studio, the flag is enabled by default. This marks nonconforming code (related to MSVC + a CPP-standard).

@fabratu fabratu mentioned this pull request Mar 26, 2024
Merged
@c-bebop c-bebop self-requested a review March 26, 2024 19:34
c-bebop
c-bebop reviewed Mar 26, 2024
View reviewed changes
c-bebop
c-bebop requested changes Mar 26, 2024
View reviewed changes
Copy link
Copy Markdown

@c-bebop c-bebop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if I understand the scope of this PR correctly. Everything in ci.yml makes sense. The format changes in C++ files as well as logic changes in ErdosRenyiEnumeratorGTest.cpp however seem to me out of scope of this PR.

@fabratu
Copy link
Copy Markdown
Member Author

fabratu commented Mar 26, 2024

I am not sure if I understand the scope of this PR correctly. Everything in ci.yml makes sense. The format changes in C++ files as well as logic changes in ErdosRenyiEnumeratorGTest.cpp however seem to me out of scope of this PR.

Thx for the review - this is partially answered in the comments :) Scope is: fixing CI issues (see master builds) + updating versions. Maybe you are right though, in future I will split those PRs. Also makes it easier to review them.

@fabratu fabratu force-pushed the 20240311_ci_update branch from b958185 to db19446 Compare March 26, 2024 20:48
@fabratu fabratu mentioned this pull request Mar 27, 2024
Merged
c-bebop
c-bebop approved these changes Mar 27, 2024
View reviewed changes
Copy link
Copy Markdown

@c-bebop c-bebop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clarification!

@fabratu
Copy link
Copy Markdown
Member Author

fabratu commented Mar 27, 2024

Will merge this early, since fix is needed for CI.

@fabratu fabratu merged commit ad7067b into networkit:master Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@c-bebop c-bebop c-bebop approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fabratu @c-bebop