fixing small leak on exception on the transport-epoll-native allocation#3844
Closed
clebertsuconic wants to merge 1 commit into
Closed
fixing small leak on exception on the transport-epoll-native allocation#3844clebertsuconic wants to merge 1 commit into
clebertsuconic wants to merge 1 commit into
Conversation
|
AUTOMATED MESSAGE for ADMINS: |
Member
|
@netkins accept |
Member
clebertsuconic
force-pushed
the
master-exception
branch
4 times, most recently
from
May 29, 2015 20:56
aaf10b5 to
4905535
Compare
Contributor
Author
|
I already did the cla.. about a month (3 weeks maybe) ago |
Motivation: the JNI function ThrowNew won't release any allocated memory. The method exceptionMessage is allocating a new string concatenating 2 constant strings What is creating a small leak in case of these exceptions are happening. Modifications: Added new methods that will use exceptionMessage and free resources accordingly. I am also removing the inline definition on these methods as they could be reused by other added modules (e.g. libaio which should be coming soon) Result: No more leaks in case of failures.
clebertsuconic
force-pushed
the
master-exception
branch
from
May 29, 2015 21:00
4905535 to
0002632
Compare
Contributor
Author
|
@normanmaurer I have made a mess on my git clones to fix these diffs.. I probably created a thousand jobs on the netkins.. but I don't have authorization to cleanup them... I'm settled now.. if you could please cleanup the queue since I don't have authorization to kill a job. |
Member
|
@clebertsuconic - Awesome! Thanks for the fix! |
Member
|
@clebertsuconic thanks again! Cherry-picked into 4.0 (ea0f84e), 4.1 (70e3d17) and master (c0e889a) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
the JNI function ThrowNew won't release any allocated memory.
The method exceptionMessage is allocating a new string concatenating 2 constant strings
What is creating a small leak in case of these exceptions are happening.
Modifications:
Added new methods that will use exceptionMessage and free resources accordingly.
I am also removing the inline definition on these methods as they could be reused by
other added modules (e.g. libaio which should be coming soon)
Result:
No more leaks in case of failrues.