Repository navigation
Fix float matching in read-only HTTP/2 headers - #18294
Merged
Merged
Conversation
Motivation: ReadOnlyHttp2Headers.containsFloat always returns false, even when a matching float value is present. Modifications: Convert the supplied float to text and delegate to the existing header lookup. Result: Float matching follows the other numeric header lookups.
Cover matching floats, repeated header values, a different value, and an absent header name.
✅ All tests passed ✅🏷️ Commit: 2a540ca Learn more about TestLens at testlens.app/docs. |
normanmaurer
added
needs-cherry-pick-4.1
Contributor
|
Auto-port PR for 5.0: #18361 |
github-actions
Bot
removed
the
needs-cherry-pick-5.0
Contributor
|
Auto-port PR for 4.1: #18362 |
github-actions
Bot
removed
the
needs-cherry-pick-4.1
normanmaurer
pushed a commit
that referenced
this pull request
Nov 13, 2026
Auto-port of #18294 to 5.0 Cherry-picked commit: dbef5f3 --- Motivation: `ReadOnlyHttp2Headers.containsFloat` always returns false, even when a matching float value is present. Modification: Convert the supplied float to text and use the existing header lookup. Add a focused regression for matching values, duplicate header names, a different value, and an absent name. Result: Float matching is consistent with the other numeric header lookups. Fixes #18260. Co-authored-by: Kayokoi <[email protected]>
normanmaurer
pushed a commit
that referenced
this pull request
Nov 13, 2026
Auto-port of #18294 to 4.1 Cherry-picked commit: dbef5f3 --- Motivation: `ReadOnlyHttp2Headers.containsFloat` always returns false, even when a matching float value is present. Modification: Convert the supplied float to text and use the existing header lookup. Add a focused regression for matching values, duplicate header names, a different value, and an absent name. Result: Float matching is consistent with the other numeric header lookups. Fixes #18260. Co-authored-by: Kayokoi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
ReadOnlyHttp2Headers.containsFloatalways returns false, even when a matching float value is present.Modification:
Convert the supplied float to text and use the existing header lookup. Add a focused regression for matching values, duplicate header names, a different value, and an absent name.
Result:
Float matching is consistent with the other numeric header lookups.
Fixes #18260.