DNS: Ensure query id is not predictible#16870
Merged
Merged
Conversation
Motivation: Netty's DNS resolver uses a predictable PRNG for generating DNS transaction IDs and defaults to a static UDP source port. This combination reduces the entropy of DNS queries, enabling DNS Cache Poisoning (Kaminsky attack). Modifications: - Replace usage of ThreadLocalRandom with SecureRandom Result: query id is not predictible anymore
normanmaurer
added
the
needs-cherry-pick-5.0
Contributor
|
Could not create auto-port PR. |
Member
|
Port to 5.0: #16914 |
chrisvest
removed
the
needs-cherry-pick-5.0
chrisvest
added a commit
that referenced
this pull request
Jun 5, 2026
- #16881 - #16876 - #16866 - #16870 - #16837 - #16858 - #16882 - #16893 --------- Co-authored-by: Norman Maurer <[email protected]> Co-authored-by: Violeta Georgieva <[email protected]> Co-authored-by: Szymon Habrainski <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Netty's DNS resolver uses a predictable PRNG for generating DNS transaction IDs and defaults to a static UDP source port. This combination reduces the entropy of DNS queries, enabling DNS Cache Poisoning (Kaminsky attack).
Modifications:
Result:
query id is not predictible anymore