Configurable bound on RedisArrayAggregator#16858
Merged
Merged
Conversation
normanmaurer
added
the
needs-cherry-pick-5.0
Motivation: The RedisArrayAggregator was pre-allocating the aggregating ArrayList instance based on just the array header message. Modification: Add a RedisArrayAggregator constructor that takes a max number of elements as an argument. Deprecate the other constructor and make it use 1.000.000 as a default, defined by a new system property. Why 1.000.000? It seemed big enough to not cause too many compatibility problems from this change, yet small enough to somewhat constrain the resource usage from nefarious peers. Result: Less exposure to excessive resource usage by adversarial peers.
Contributor
|
Could not create auto-port PR. |
Member
|
Port to 5.0: #16914 |
chrisvest
removed
the
needs-cherry-pick-5.0
chrisvest
added a commit
that referenced
this pull request
Jun 5, 2026
- #16881 - #16876 - #16866 - #16870 - #16837 - #16858 - #16882 - #16893 --------- Co-authored-by: Norman Maurer <[email protected]> Co-authored-by: Violeta Georgieva <[email protected]> Co-authored-by: Szymon Habrainski <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The RedisArrayAggregator was pre-allocating the aggregating ArrayList instance based on just the array header message.
Modification:
Add a RedisArrayAggregator constructor that takes a max number of elements as an argument. Deprecate the other constructor and make it use 1.000.000 as a default, defined by a new system property.
Why 1.000.000? It seemed big enough to not cause too many compatibility problems from this change, yet small enough to somewhat constrain the resource usage from nefarious peers.
Result:
Less exposure to excessive resource usage by adversarial peers.